Command fillmegamap incorrectly overrides

Question

Command fillmegamap incorrectly overrides

naqaden opened this issue 6 years ago · 4 comments

naqaden commented 6 years ago

To be clear, I haven't experienced any problem myself, but I use the HelpFixer mod and it's reporting the following 4x in a row each startup:
[Server thread/WARN] [com.matthewprenger.helpfixer.HelpFixer]: Command fillmegamap incorrectly overrides compareTo: %s

Stormwind99 · Answer 1 · 2018-10-19T20:51:42.000Z

Thanks! I wonder what is incorrect about it...

naqaden · Answer 2 · 2018-10-19T21:34:23.000Z

This, which does this.

Stormwind99 · Answer 3 · 2018-10-19T21:43:53.000Z

Ah, looks like ICommands need to implement a proper IComparable<>.compareTo().

Easiest way appears to be to replace implementing ICommand with extending net.minecraft.command.CommandBase.

Fixed in next release. Thanks!

naqaden · Answer 4 · 2018-10-19T21:45:20.000Z

Nice, thank you.

Share to