Having Megaloot Armor equipped messes with the player's damage dealt
Ghostrider231 opened this issue ยท 2 comments
Version: 1.12.2-0.2.24
While attacking any mob with at least a piece of megaloot armor increases your damage dealt even though it doesn't specificity mention about any damage buff.
If you had a 30 Damage sword while having some of the armor equipped, but if you get damaged, your damage dealt with that sword is debuffed as if you were attacking unarmed (16 to 22 DMG), until you at least hit something or switch items.
Reproducing: (Happens in Both modes : Creative/Survival)
- Get a MegaLoot Case. (Any)
- Open it until you get a piece of armor.
- Equip that said piece of armor.
- Get a spawn egg. (I'll either go for creepers or husks)
- Spawn as many mobs as you like. (husks or creepers)
- Proceed to punch said mob whilst MegaLoot armor was equipped.
- Your Damage will rocket up to 1 to 16 or even 22! (For 30 DMG Swords, it'll go from 30 to 16 or 22)
(If it doesn't do the sky rocketed damage reequip the armor or take damage)
If you did switch out of a MegaLoot Weapon your damage will be reverted back to normal, but as so as you take damage, your attack damage sky rockets again.
During Debugging from your source code:
According to MLItemArmor and MLItem.
Commenting out 'Multimap' in MLItemArmor seems to stop the unintentional damage dealt modifier, but removes the abilities that are obtained from said MegaLoot Armor.
Update: Inside of MLItem.java, Adding another condition argument "armorpoints < 1" inside of "attackdamage > 0" seems to fix the issue?
Old line of code: if (attackDamage > 0)
New line of code: if (attackDamage > 0 & armorPoints < 1)
[I'm not a great java coder, I'm still learning this new coding language. So excuse me of my skills]
Different Bug that i've also found:
Another Bug that i've found is that the Samurai Armor (most notably the helmet) are rendered in one solid color and feels like you're wearing a mob head.
I am setting the standard atribute modifiers for all items, any armor piece, even when jot indicated in the tooltip, has a chance to roll a strength attribute. It should stack with any other mod using attribute modifiers but I will research why is this happening. Thanks for the report.
