Mekanism 1.12.2 Community Edition

Mekanism 1.12.2 Community Edition

1.9k Downloads

[BUG]: Digital Miner Voids other Mek Machines

SpoilersMC opened this issue ยท 0 comments

commented

Describe the bug

If a Digital Miner is configured to mine any other machine from mekanism, the block will be erased from existence
this is due to how the Digital Miner attempts to determine item drops for the target block
Digital Miner on operation calls MinerUtils.getDrops():
https://github.com/Thorfusion/Mekanism-Community-Edition/blob/1.7.10/src/main/java/mekanism/common/tile/TileEntityDigitalMiner.java#L251
MinerUtils.getDrops() calls Block.getDrops():
https://github.com/Thorfusion/Mekanism-Community-Edition/blob/1.7.10/src/main/java/mekanism/common/util/MinerUtils.java#L35
Block.getDrops() calls Block.getItemDropped(), BlockMachine overrides getItemDropped() and returns null:
https://github.com/Thorfusion/Mekanism-Community-Edition/blob/1.7.10/src/main/java/mekanism/common/block/BlockMachine.java#L754

in conclusion every single BlockMachine that a Digital Miner attempts to collect will be voided

To Reproduce

Configure a Digital Miner to mine any machine from Mekanism

Expected behavior

Collect the block item correctly.

Mekanism Version

9.10.29

Minecraft Version is this regarding?

1.7.10

What OS are you seeing the problem on?

No response

Name of modpack if applicable

No response

Version of said modpack if applicable

No response

Screenshots

No response

The crash report in folder ./crash-reports (both server and client logs)

N/A

Please provide the following other files

No response