Mekanism

Mekanism

111M Downloads

[7.0.0.70] Bin crafting handler failure (adding/removing items in crafting grid)

Tallinu opened this issue ยท 3 comments

commented

The crafting recipes for adding to or removing from a picked-up bin using crafting (player inventory or crafting table) don't work properly.

Placing a stack of items plus a bin in a crafting grid and taking the output consumes only one item out of the stack while adding the full quantity of the stack to the new bin. Placing a bin and a stack of items in the grid and then changing the size of the stack of items does not change the resulting bin in the output slot.

(For example, start with a bin and 1 dirt, then add 63 more dirt. Remove output, and you have a bin with 1 dirt in it and 63 dirt left in the crafting grid. Start with 64 dirt, add a bin, remove output, you get a bin with 64 dirt and 63 dirt left in the grid.)

A bin containing items, when placed in the grid by itself, gives you up to a single full stack of the item as usual but the bin itself, and any remaining contents, are lost.

Additionally, placing an enchanted tool into a bin and then picking up the bin results in the loss of the enchantments whether you remove the item via crafting or by placing the bin (this part is probably caused by the same problem as #1302 and may in fact be a separate issue, so I'll comment there).

commented

Thanks a bunch, this is a major issue and I can't believe I didn't catch it. Fixing right now.

EDIT: The second issue you mentioned is related to the mana beans issue.

commented

Fixed!

commented

I see that commit is in the 1.8 branch. I'm curious, will that get back-ported to 1.7.10 at some point?