Mekanism

Mekanism

111M Downloads

Logistical Transporters not sending NBT data of items in transit

pwestling opened this issue · 4 comments

commented

Currently, the serialization methods of the TransporterStack object do not include the ItemStack's NBT data in the data array. This has the effect that on the client side, the ItemStacks going through a logistical transporter do not have their NBT data present, which affects rendering in some cases: for example, enchanted items going through a transporter do not glow. I'm currently working on a mod which makes heavy use of NBT data to determine textures, and my items show up as missing textures in Mek pipes due to this issue.

I recognize that this may have been a design decision to avoid larger packets, but it does potentially affect game play, so I thought I'd bring it up.

There's some chance that this is related to #1845 (also a problem on our server) , as I imagine that the item gets dropped into the chest NBT-less on the client side at first. Depending on how Forestry resolves this case, it could cause the NBT data to change.

commented

Yeah, I think the two issues are related. I think the bee thing is our "Are these stacks equal?" method not taking NBT into account.

commented

I'm working on a pull request to fix both issues. Should have it up this afternoon - if anybody else plans on fixing before then let me know. —
Sent from Mailbox

On Mon, Sep 22, 2014 at 10:10 AM, Ben Spiers [email protected]
wrote:

Yeah, I think the two issues are related. I think the bee thing is our "Are these stacks equal?" method not taking NBT into account.

Reply to this email directly or view it on GitHub:
#1848 (comment)

commented

Awesome, thanks. I'm a little burned-out at the moment, and Aidan doesn't seem to be around either so that will be a big help

commented

Community PRs are always good :)