Mekanism

Mekanism

111M Downloads

[Dev-branch 8.0.0] Server-side crash from attempting to load tickable sound class

kotoroshinoto opened this issue ยท 20 comments

commented
commented

Have the same crash, here is my crashlog: http://pastebin.com/9eDvf5WR

commented

Seems that some recipe stuff somehow is referencing client side stuff.

commented

looking at the code in WasherRecipe its not immediately apparent to me HOW its referencing client stuff.

commented

stacktrace references these lines: (in the caused by section)

public FluidInput waterInput = new FluidInput(new FluidStack(FluidRegistry.WATER, TileEntityChemicalWasher.WATER_USAGE));

this(new GasInput(input), new GasOutput(output));

commented

Perhaps it interacts with the chemical washer class somehow causing the server to attempt loading the client side sound stuff?

commented

New tile sound implementation is a bit rough with its client references, I'm trying a fix but it's acting weird. I'll push a fix as soon as I figure it out.

commented

src/main/java/mekanism/common/tile/TileEntityNoisyElectricBlock.java has the import for mekanism.client.sound.IResettableSound; which is likely involved in this.

commented

Yes. The import won't necessarily matter though unless it is referenced...

commented

looks like line 22 might be the culprit.

commented

In the entityNoisyelectric class i mean

commented

the sound member variable has type IResettableSound which extends import net.minecraft.client.audio.ITickableSound;

commented

Fixed

commented

Yeah, it seems to happen the INSTANT TileEntityChemicalWasher is loaded.

commented

is the code in an uncommittable state atm? I notice there is no new commit, so as of yet , can't test for further bugs.

commented

There we go, forgot to push ^^

commented

odd... now i'm getting a buildcraft related crash that I wasn't getting before.

commented

no, without mekanism it launched without a crash.

commented

@unpairedbracket, just revert and add your change - my fix was definitely messy :P

commented

Does that happen without Mekanism installed? Also, @aidancbrady, I figured out a solution to the server-side sound issues that works and seems to avoid the issues you were encoutering, and doesn't require the usage of a wrapper class. Shall I revert it before I pull, or go with my solution in a merge?

commented

I put the crash report and the other message into a new issue, since i'm not certain it has anything at all to do with the sound problem.