Mekanism

Mekanism

111M Downloads

[8.0.0] Client-side code being accessed by server causes crashes

kotoroshinoto opened this issue ยท 13 comments

commented

Previously the sound error: #2223

now this one: http://paste.fedoraproject.org/199790/71315814

commented

oops

commented

fixed the original comment

commented

sorry, forgot to copy the URL, fixed it.

commented

^That's the BuildCraft API issue crash, I think you got the wrong link.

commented

Our getRenderType() was assuming it was only going to be called on the client side, and was referencing our ClientProxy class (which is client side-only), so causing crashes on the server-side when EU called getRenderType() on the server side. I've now moved the fields it was referencing to the common proxy, which is available on the server side.

commented

Hmm, that's odd. getRenderType shouldn't be called on the server side, I'm pretty sure, but it's not @SideOnly(Side.CLIENT)ed in the Block source, so I guess that is our issue?

...5 minutes later...

I've just had a look at EU's issue tracker, multiple people have reported this to RWTema, and apparently it's used by the vanilla server. I'll move it to not be client-only in Mekanism code, then.

commented

Is there an alternate solution or was there code for that that WAS set to client only that was causing a crash?

commented

Yeah, I'll go through them all and check. Thanks for helping us smooth all this over before release.

commented

Fixed Generators, and an issue with reactor controllers. Let me know if you find any more

commented

Solar panels did it too.
should probably go through all the machines and make sure your fix gets applied
@unpairedbracket

commented

when i place machines in the world that make noise, it crashes server

commented

oh i dont mind, I really like mekanism ;D

commented

Closing as I don't see where else this could mess up. If it does, though, please comment here and I'll reopen!