Liquid Monitor Crash with Fluid Pipes
nerdnosyd opened this issue ยท 3 comments
Crash report: http://pastebin.com/Q99GRc7J
Placing an RFTools Liquid Monitor and selecting a Mekanisms liquid pipe with it immediately crashes and corrupts the world, requiring mcedit to remove the offending blocks.
unrelated comment about how its not a duplicate bug thanks for the report, will investigate.
It's an easy issue. Facing is nullable in any capability related thing and RF Tools uses it, Mekanism doesn't.
It results in a nullpointer at the folowing line:
https://github.com/aidancbrady/Mekanism/blob/1.10/src/main/java/mekanism/common/multipart/PartSidedPipe.java#L158
Sollution would be adding a case at:
https://github.com/aidancbrady/Mekanism/blob/1.10/src/main/java/mekanism/common/multipart/PartMechanicalPipe.java#L259
Which allowes null and returns it (Currently not able to make a pull request)
if(from == null || getConnectionType(from) != ConnectionType.NONE)
Little note: should be fixed for every kind of pipe/fluid capability usage.
On the second look, someone already has a fix available.
See #4185