Mekanism

Mekanism

111M Downloads

Tinkers Construct Crash

yepidoodles opened this issue · 12 comments

commented

Ya this has been a bug for a long time. The workaround is to turn off the item rendering in Tinkers but that sucks. Something Mek is doing really pisses it off and makes you crash to desktop repeatedly while crafting some stuff in there. Haven't found a trend as it seems to be random but I know I was making a jetpack once on a crafting table and it did that.

commented

As far as I can tell it's due to the excessive amount Mekanism uses NBT data.

commented
commented

I've tried every logical and hacky fix to get the TC rendering working but I just can't seem to figure it out. Closing, but I'll still try and find a fix when I have a chance.

commented
commented

What I've done on my end (band-aid solution) was just a try-catch to ignore the error. Renders still fine in the world etc and just doesn't render as a model on top of the Tinker's Crafting Station.
@aidancbrady

commented

Per #4798 @Alphanos discovered a link to alwaysSetupTerrainOffThread Forge config as having an impact on whether this crash happens or not. Perhaps this is new clues to tracking down what could be causing these Tinker's render issues?

commented

@OrdinatorStouff we fixed this in Mekanism a while ago by checking for an OpenGL context before doing the hacky stuff. Any relation to it happening in the recent issue with Mekanism items is likely coincidence.

We check for device capabilities which will throw the no context exception (which we catch). I'm not sure how that would cause issues with the thread that actually has the context.

commented

If the current crash involves Mekanism items only by coincidence, does that mean that I should be reporting the current issue to Forge? I don't have much experience knowing whether Forge issues are typically reported by end users or by mod developers. Thanks!

commented

If it's crashing in a Tinkers table, likely no.

Can it be reproduced with just Mek & Tinkers & alwaysSetupTerrainOffThread?

commented

Can it be reproduced with just Mek & Tinkers & alwaysSetupTerrainOffThread?

Yes. When alwaysSetupTerrainOffThread is enabled, the crash can be reproduced with only Mekanism and Tinker's Construct.

commented

🤔