Turbines are now really laggy and opaque

Question

Turbines are now really laggy and opaque

josephcsible opened this issue 7 years ago · 13 comments

josephcsible commented 7 years ago

Our turbines now cause extreme lag, and are opaque due to steam instead of being translucent. This started happening in the new version of Mekanism. I tracked it down to commit 1e046a3 (pinging @thiakil).

Here's what it looks like without that commit (correct):

And here's what it looks like with that commit (buggy):

Versions:
Minecraft 1.12.2
Forge 14.23.1.2554
Mekanism (and MekanismGenerators) 9.4.2

thiakil · Answer 1 · 2017-11-26T21:52:36.000Z

It's probably the commit after that which deals with mostly gui rendering of gasses. The kinked commit should only affect tube rendering

josephcsible · Answer 2 · 2017-11-26T21:53:53.000Z

I did a build of the latest HEAD, which had the problem. Then I reverted 1e046a3 alone, leaving the commits after it, and didn't have the problem.

thiakil · Answer 3 · 2017-11-26T21:59:35.000Z

Didn't gave which problem? (there's no way that could affect rendering)

josephcsible · Answer 4 · 2017-11-26T22:07:05.000Z

I know it seems unlikely, but I've tested and re-tested, in the dev environment and in a regular game environment, and both problems are linked to that commit and that commit alone.

josephcsible · Answer 5 · 2017-11-26T22:18:40.000Z

Can one of you try exactly what I did on your computer, just to see if it's reproducible?

Check out latest git
Open this world with it: https://drive.google.com/file/d/1DV-WgqdMW9ZlfoHWdGCb8Q3SxadkF5Lv/view?usp=sharing (it will be laggy and opaque)
Revert 1e046a3, with git revert 1e046a3 or git show 1e046a3 | patch -p1 -R or something
Open the world again (it will be fast and correct)

thiakil · Answer 6 · 2017-11-26T22:24:34.000Z

I have seen the opaqueness in my test world, but not the lag. ~~Either way it's a symptom, not so much a cause as there shouldn't be block updates bouncing around like that~~

tomelfring · Answer 7 · 2017-11-26T21:15:39.000Z

Are both issues not present in the version before that commit or only he lag issue? The transparency is probably caused by 532744f

josephcsible · Answer 8 · 2017-11-26T21:18:21.000Z

Both issues are present with 1e046a3 and absent without it. 532744f didn't seem related in my testing.

thiakil · Answer 9 · 2017-12-03T11:09:44.000Z

Fixed in dev

josephcsible · Answer 10 · 2017-12-03T18:36:53.000Z

Thanks. I can confirm that the latest dev build fixes both problems for me.

Xiaminou · Answer 11 · 2017-12-13T00:54:59.000Z

Is it supposed to be fixed in this build? Because I have an FPS issue with max size turbine. It drops my FPS from 200 to 20.

thiakil · Answer 12 · 2017-12-13T01:00:35.000Z

It should be fixed there, yes

Xiaminou · Answer 13 · 2017-12-13T01:04:42.000Z

Well then I suppose I should open a different issue.

Share to