[1.12.2] Gas tanks seem to not implement drawGas despite allowing output sides to be set

Question

[1.12.2] Gas tanks seem to not implement drawGas despite allowing output sides to be set

asiekierka opened this issue 7 years ago · 5 comments

asiekierka commented 7 years ago

Is this an intentional design decision or an omission?

tomelfring · Answer 1 · 2017-12-16T11:56:02.000Z

My guess (no guarantees it would be correct) is that the gas tank pushes the gas when set to output. Allowing pipes (and other stuff) pull would be a bit double..

asiekierka · Answer 2 · 2017-12-16T11:57:31.000Z

This might cause trouble with potential other mods which cannot support a push-based setup, however. Especially as other machines can be extracted from...

tomelfring · Answer 3 · 2017-12-17T12:20:48.000Z

This is looking good. No weird side-effects.
Feel free to test :)

tomelfring · Answer 4 · 2017-12-16T18:37:51.000Z

Aaah.. I now see why you reported it.. YNot!
Nice, it was somewhere on my todo list to look into to make, nice to see it already has happened.

I'll see what I can do to make it work :)

tomelfring · Answer 5 · 2017-12-16T19:12:58.000Z

@asiekierka I made some changes. Will test tomorrow if it works with YNot & XNET and it doesn't have any side effects (see PR #4870).

Share to