Mekanism

Mekanism

111M Downloads

Jetpack drains fuel while being in spectator mode.

mainrs opened this issue ยท 5 comments

commented

Steps to reproduce:

  1. Equip jetpack and load with fuel.
  2. Enable hover mode.
  3. Switch to spectator mode. The jetpack sound is still active as are particles and the jetpack HUD. You can see the drain there too.

Version (make sure you are on the latest version before reporting):

Forge: 14.23.1.2566
Mekanism: 9.4.3.330

Edit: Might fix this. Never contributed to Mekanism but a simple isSpectator check should be fairly easy.

commented

While I'd love to blame this on user error (shouldnt really be using anything in spectator mode, no?) it is indeed an oversight

commented

Was more by accident than anyting else. I wanted to take a look at how my setup looks under the earth and thought that spectator might be the easiest ^_^
But you are right, normally you aren't using any items in spectator though.

commented

@thommy101 Ah, that explains why it didn't work on my fork. I didn't override the ClientTickHandler ๐Ÿ˜„. TIL I guess ^^ Thanks for the work!

commented

No problem ;)

The magic of client and server side code.... Both need to be changed :)

commented

I wonder why there needs to be two classes that basically contain the same things tbh. Wouldn't one source of truth (server) be more efficient in general? And just put the render specific code into the client and sync the rest. But they probably had their reasons to write it that way ๐Ÿ˜„