Mek Generators Crash with Astral Sorcery 1.9.0
brisingraerowing opened this issue ยท 4 comments
Please use the search functionality before reporting an issue. Also take a look at the closed issues!
Issue description:
Crashes with Astral Sorcery 1.9.0
Steps to reproduce:
- Run Mekanism Generators and AS 1.9.0 together
- Crash on startup
Version (make sure you are on the latest version before reporting):
Forge: 2705
Mekanism: 9.4.11.346
Other relevant version: 1.9.0
If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)
See the log in HellFirePvP/AstralSorcery#749. I get the same crash.
Other
The fact that this method doesn't check the generator type for null
seems to be the root of the issue, as AS is looping over items and getting their stack sizes for one of its features.
It hasn't crashed for me (ironically because another mod is causing the serverStartEvent to fail), but I've been getting the same error when closing a world, which hardlocks the game.
Running Mekanism 9.4.11.346 on forge 14.23.3.2694, also tested with forge 14.23.4.2707
No crash log, but here's the client log of me starting the game, opening a world, and closing it.
Exception caught during firing event net.minecraftforge.event.AttachCapabilitiesEvent@4cadccd3: java.lang.NullPointerException: null at mekanism.generators.common.item.ItemBlockGenerator.getItemStackLimit(ItemBlockGenerator.java:95) ~[ItemBlockGenerator.class:?] at net.minecraft.item.ItemStack.func_77976_d(ItemStack.java:248) ~[aip.class:?] at hellfirepvp.astralsorcery.common.enchantment.amulet.EnchantmentUpgradeHelper.isItemBlacklisted(EnchantmentUpgradeHelper.java:176) ~[EnchantmentUpgradeHelper.class:?]
interestingly, this also seems to affect RFTools Dimensions-
Failed to create a dimlet for block mekanismgenerators:generator! Please report to the correct mod! java.lang.NullPointerException: null at mekanism.generators.common.item.ItemBlockGenerator.getItemStackLimit(ItemBlockGenerator.java:95) ~[ItemBlockGenerator.class:?] at net.minecraft.item.ItemStack.func_77976_d(ItemStack.java:248) ~[aip.class:?]
Not sure why things are trying to make wildcard items for it, but it should no longer crash.