Mekanism

Mekanism

Mods
111M Downloads

Teleporter status can desync

Johni0702 opened this issue ยท 3 comments

commented

Status updates are only sent to players within a 40 block radius:

Mekanism/src/main/java/mekanism/common/tile/TileEntityTeleporter.java

Line 165 in 0701203

Mekanism.packetHandler.sendToAllAround(new TileEntityMessage(this), Coord4D.get(this).getTargetPoint(40D));

Instead it should probably be sendToAllTracking.

How to reproduce:

  • Have player 1 stand more than 40 blocks away from the teleporter but still close enough for it to be loaded
  • Activate teleporter with player 2
  • Observe incorrect state for player 1 until another update is triggered

(Note: I haven't actually tried those steps. I just ran across it while adding compatibility for the teleporter to a different mod.)

commented

I believe your suspicion is correct. I am going to also go through the few other remaining uses of sendToAllAround and see if they should be updated as well (it is likely they should)

commented

Should be fixed by 63679fe (forgot to reference the issue from the commit)

commented

Version 9.8.0 was just released and should sync to the twitch client within the next couple hours.