Mekanism

Mekanism

111M Downloads

Nucleosynthesizer shows confusing/wrong antimatter cost

Paspartout opened this issue ยท 4 comments

commented

Issue description:

The JEI Recepie view of the Nucleosynthesizer shows 200mB for each recepie which is way too much and confusing in my opinion. Looking at the code it seems like it somehow displays the mB/t but I think it should show the amount of mB needed for one operation.

confusing_antimatter_jei

Steps to reproduce:

  1. Load up any game/save using Mekanism 10 and JEI
  2. Press U or right click on antimatter gas in JEI to see usages
  3. Hover over the gas tank in the Nucleosynthesizer, it shows 200mB antimatter usage for all recepies.

Version (make sure you are on the latest version before reporting):

Forge: 35.0.18
Mekanism: 10.0.17 (latest version from 1.16.3 branch)

commented

Aha! Looking at it, it is because the JEI code is copy pasted and assumes a per tick usage but the nucleosynthesizer actually passes to the recipe that it has a zero per tick usage, should be trivial to fix for 10.0.18.

commented

I am trying to get into the mekanism codebase myself at the moment, so I might try to fix it myself.
Would making the NucleosynthesizingRecipe similar to the MetallurgicInfuserRecipe be a good fix for this?

commented

Thanks for the hints! I figured the first 3 changes out myself but was not paying attention to the setIngredients() method.
My PR should fix it:
fixed