Basic mechanical pipe pulling from blood altar crashes game
danbalarin opened this issue ยท 3 comments
Issue description:
When mechanical pipe is set to pull from blood magic altar the game instantly crashes (singleplayer and multiplayer server) and then crashes every time the chunk is loaded.
Steps to reproduce:
- Place mechanical pipe next to blood altar
- Set the pipe to suck from altar
- Watch game crash
Version (make sure you are on the latest version before reporting):
Forge: 35.1.13
Mekanism: 10.0.18.445
Other relevant version: Enigmatica 6 Modpack
If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)
Crash report:
https://pastebin.com/Ha8YEpL0
That isn't what the issue is at all, my first thought was that it is because the capability is not implemented properly and is thus erroring because it is invalid and doesn't say it is no longer valid. Upon closer inspection it is because Blood magic is still using the 1.12 way of handling fluids and returning null from a Nonnull method. I am not going to add null checks in every possible spot just because a mod might improperly return null from a nonnull method.
Not mekanism, blood magic isn't implementing capabilities properly: https://github.com/WayofTime/BloodMagic/blob/1.16.3/src/main/java/wayoftime/bloodmagic/tile/TileAltar.java#L229
As far as I can see, the problem is caused by Mekanism. Blood magic may not implement something like they are supposed to, but every external facing interface should be at-least null checked. Blood magic may fix it, but then some other mod creator may do the same mistake and the world destroying bug will be back...