Obsolete NBT tag mekData after emptying chemical tanks
menof36go opened this issue ยท 0 comments
Issue description
This bug "invisibly" (unless the user is familiar with NBT and has advanced tooltips) breaks item sorting and filtering for multiple mods.
Imagine the following scenario:
You want to transport gases over a long distance from a production site. To do so, you fill the gases into tanks you import into your production generators using a method of your choice. You transport the tanks using a mod of your choice. The tanks are emptied at their target location and consequently reenter the empty tank supply to be filled up again in the gas production facility. The problem arises, because newly crafted tanks and "reused" tanks are not indistinguishable, despite having no indicator of difference to the naked eye. A user can fix this problem by creating two seperate entries in his sorter of choice (be it a logistical sorter or an me export bus for example), but this is not a user friendly solution since the issue is not necessarily visible at all. So a random user is left with a logistical sorter that is seemingly configured correctly, but doesnt forward an item that seemingly fits all the criteria, due to difference in nbt values.
A possible and probably easy fix would be to remove the mekData GasTanks tag from a tank if it's isEmpty() function returns true. I would do it myself but I cant get this repository to compile and there's not a lot of information on how to set it up correctly, sadly.
I do not know if this has been fixed in a new version, but since i was forwarded here from the discord, i do not believe that to be the case.
Best regards,
Fabi
Steps to reproduce
- Empty any chemical tank filled with a gas
- Empty chemical tank still has mekData "GasTanks"
- (This probably is also the case for tanks filled with other substances)
Minecraft version
1.16.x or earlier (No longer being developed)
Forge version
36.2.32
Mekanism version
Older
Other relevant versions
No response
If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)
No response