Need 1.21.1
SussyBob opened this issue · 15 comments
Are there any plan for a future update or this mod is basically discontinued? I really love this mod..
there is nothing left to do?
Mojang fixed the memory leaks, so this mod is no longer needed
there is nothing left to do?
Mojang fixed the memory leaks, so this mod is no longer needed
I still get memory leaks when loading large amounts of chunks, and then unloading or relogging
Mojang fixed the memory leaks, so this mod is no longer needed
With version 1.21.3, it seems that this error has reappeared, the game occupies more than 3.6gb of total ram (while version 1.21.1 only occupies ~2.8gb), while the JVM setting is 2gb of ram for the game
Mojang fixed the memory leaks, so this mod is no longer needed
With version 1.21.3, it seems that this error has reappeared, the game occupies more than 3.6gb of total ram (while version 1.21.1 only occupies ~2.8gb), while the JVM setting is 2gb of ram for the game
I hate how finicky it is sometimes.
@FxMorin, seems everyone needs your help again =)
Are you using any other mods?
Also, I wouldn't consider 3.6GB a memory leak. Im honestly surprised it runs with 3.6GB amount of memory at all. Theres no way the game can run with only 2GB of memory, in any stable capacity.
If you crash due to an OutOfMemoryException. You can get a heap dump and send it to me and I'll look into it.
To get a heap dump when you crash, add the following JVM flags:
-XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/some/path/minecraft-heapdump.bin
Change the path to somewhere accessible.
i feel like people need some education about what memory leaks are. if you know what a memory leak truly is, please ignore this comment. note that this is a simplification of what memory leaks are, and skips some nuances such as the specific method of leaking memory. please use chatgippity or google to look up all ways to leak memory in java if you are interested.
resources in an operating system is limited, and is therefore requested by programs from the OS on demand. memory is one of these resources, and is usually requested from the OS using programming language abstractions. under all of these abstractions lie a memory allocator's alloc() function (malloc(), calloc(), etc...). every program has to obey these rules, demanding memory from the OS, and releasing it back when it is done.
for manually memory-managed programs, it is crucial for the program to release the memory back to the OS when it is done with it. however, when this crucial rule is broken, a memory leak occurs. the program, at some point, loses the last pointer to the memory it requested, without telling the OS it stopped using that specific memory. the OS memory allocator can not possibly know whether the program is still using the memory or not, therefore it keeps it alive as long as the program is running. java is a garbage-collected language, which means the language never actually lets you leak memory, but using unsafe functions and raw memory allocator calls, this is more than possible to achieve.
this is where mojang comes into play. in prior versions of minecraft, there was a so called "memory leak", caused by minecraft allocating memory and forgetting to release it back to the OS. this mod patched specific regions of code that lacked the release. since mojang has fixed the memory leak by actually including the memory release call (it is called free() tmyk) in newer versions of minecraft, this mod is simply not needed, and will incur other overheads such as initializing and loading the mod at the start of the game.
you don't magically get "memory leaks" just because your game uses too much ram. if you are absolutely certain that the game is leaking memory and this accumulates incrementally over time, and gets fixed when minecraft is restarted, feel free to hit the developer of the mod up.
Mojang fixed the memory leaks, so this mod is no longer needed
Good to know. Could you update please the Modrinth description to explain it? I think this helps people to understand why the mod gets not updated anymore.
