Metal Chests

Metal Chests

3M Downloads

[Quark] Adjust GUI textures to fit the Quark search bar

TimGoll opened this issue ยท 15 comments

commented

I'm ignoring your default form. I hope it is okay. You added quark support but the searchbar is too big in all your chests.

2018-08-24_20 36 43

commented

No, the upper part of the GUI is too thin. xd
I'm using the GUI textures from IronChests currently, but if @Boundarybreaker touches them up to compensate for that extra space, your problem will be solved.

commented

okay. If @Boundarybreaker has no time to do it, I can do it too. I can add a pullrequest later today. Or tomorrow

commented

Hi,
is the problem with no chest and inventory name connected to the IronChests GUI texture?
ironchests gui

commented

Yes and no. IronChests never had the inv name space by default. The text is handled in code, but the available space is obviously from the texture.

commented

Soo, you will add this feature in one of the next versions? :D
(pls with anvil re-name support^^)

commented

Whatever you'd like to do. I don't mind either way.

commented

@TheSnowyChickens Perhaps; I'd say anvil renaming should be a separate issue.

@TimGoll Have you been able to get on fixing the textures?

commented

I was ill but I think I have some time today!

Should I leave some space for "Inventory"?

commented

Sure that's fine.

commented

Okay, I tried a few things and it shouldn't be a problem. Except for the diamond chest.

Just as a reminder, the GUI looks like this.
diamond_container

Does anyone have an idea how to add a search bar to this without removing storage slots?

Currently there are 9*12=108 slots. I could change it to 8*13=104 or (if you want to squeeze it) 8*14= 112. Either way, the amount of slots chages. For compatiblity reasons, the latter one is better.

commented

That's fine. The container logic will need to be updated though.

commented

So... what size should I go for?

commented

The latter option seems to be better, since dealing w/ even numbers is always easier.

commented

okay. It looks a bit crowded though. But it should be okay. Or you add a scrolling bar. Shouldn't be too hard

commented

Closing this for now, since either Tim's PR or my dynamic GUIs will solve this at some point.