Metal Chests

Metal Chests

Mods
3M Downloads

Charset Chests Support

8-BrickDMG opened this issue ยท 4 comments

commented

Error Details

Hi,

I'm using Metal Chests and Charset Chests in a mod pack but noticed there isn't support between the two when using the chest upgrade items.

I'd like to be able to use the upgrades on the Charset chests without having to craft a new Metal Chest and then moving the items over.

Right clicking an upgrade on these chests doesn't result in a change.

Many thanks!

Environment

  • OS: Windows 10 (Client Side) & Debian 4.9.51-1 (Multiplayer Server)
  • Full Forge version: MC 1.12.2, Forge 14.23.4.2756
  • Mod version: MetalChests-v3.1.6.g7177eac.jar
commented

You can also ask Asie to add compatibility to Charset. There's a way for any mod dev to add compatibility to my upgrades. As follows:

((ItemChestUpgrade) ItemsMC.CHEST_UPGRADE).addDefaultChest(myBlock);
commented

@T145 Why don't you, instead, simply check if the item version of the chest is a valid chest in the ore dictionary? That would support every mod in one go.

commented

B/c I add handle more chest variants than just the normal upgrades. There are also the Hungry Chest upgrades to worry about. Oh and reference the README for better details on adding compatibility; the statement up there is before the formal API.

commented

Perhaps you could still check the oredict entry and simply append to it?