Metallurgy 4: Reforged

Metallurgy 4: Reforged

438k Downloads

Alteration to Tinkers Construct integration

Athveranyr opened this issue ยท 8 comments

commented

Describe the solution you'd like

Allow for all alloys and metals that have in game tools/armor (or maybe even materials that still don't have tools anyways but disabled by default?) to be made into tinkers tools again (potentially reverting the changes made in 0.2.0), then allow for metallurgy tinker materials to be disabled within the configs.

Extra: More advanced configurations such as material stats and which tinkers parts are allowed to be made form a specific material can be left for in-mod Craft Tweaker integration (noticed it was in your checklist) or external configuration with Tweakers Construct (or other similar mods).

On the subject of what was stated earlier about "potentially reverting the changes made in 0.2.0," obviously all of you, the developers, it's your mod and you can have certain materials disabled by default to provide the default experience you want for the players who play with your mod, the "unlocking all materials" just opens up more customization and development capabilities.

Why would you like this to be implemented?

This alteration to tinkers integration will allow for greater customization and re-balancing capabilities for the development of mod packs. It also will eliminate material restrictions and on top of the two previous examples it will altogether provide more freedom to the players.

Describe alternatives you've considered (optional)

(The "Extra:" section of the suggestion description)

Additional context (optional)

The summary is just unlocking all the materials for tinkers integration, and placing the enabling/disabling of metallurgy tinker materials in the configs, which then allows for additional mods to configure stats and allowed tool parts etc. ๐Ÿ˜„

commented

Along with that, I think it'll be good if there could be a config setting that allows Metallurgy to check if there has been a registered tool material already with the same name and therefore not register the Metallurgy material for it.

Looping through TinkerRegistry#getMaterialIntegrations() and checking if material isn't null and getting the identifier string should be more than enough.

commented

Talking about @SextupleTap 's suggestion:
I can say we won't implement any config to disable tinkers tools and/or material because you can already do that sort of things with mods like: https://minecraft.curseforge.com/projects/tinkersextras

About letting players make tools out of every material I see your point, we just don't want to make it so that people use Metallurgy just as a Tinkers' Construct addon, especially because it's not born with that idea, so we'll discuss about it

commented

I second this feature as I am getting problem with orespawn and MMDlib reg.

commented

This suggestion is not related at all to the issue you're talking about
@P3rf3ctXZer0

commented

removed mod - does not play nice with others.

commented

furthermore you did not follow the guide line to use PASTEBIN for the CRASHLOG.
so thank you for telling us that you removed the mod, we'll put it in our notebook
@P3rf3ctXZer0

commented

We've talked about it and decided to avoid opening up all tool materials to tinker integration for many reasons:

  • Materials that had their tinker counter-parts before 0.2.0 were materials that didn't have neither armor or tool sets in the mod itself, and we decided to disable them partially because of that
  • The ones we partially removed weren't supposted to be there since the beginning
  • Having them partially removed doesn't afflict the gameplay much
  • As an abstract concept this mod, shouldn't be considered merely as a Tinkers' Contruct Addon

Although your suggestion indeed has a pro and that is:

  • to give more customization options to modpack developers and players

However I don't think they'll be that much limited with just a few missing tool materials

So I'm going to close this issue...
further discussion is however accepted ๐Ÿ‘