Metallurgy 4: Reforged

Metallurgy 4: Reforged

Mods
438k Downloads

Tar Pits causing creating duplicate chunk generator instances

Funwayguy opened this issue ยท 0 comments

commented

General Information

Describe the bug:
Tar pit generation is creating duplicate chunk generator instances which is contributing to chunk runaway during Crackpack 3 development by @Darkosto. This is also setting off BoP debug logging in an almost identical fashion as mentioned in this issue Glitchfiend/BiomesOPlenty#1099

This particular line of code in Metallurgy looks to be at fault:
https://github.com/Davoleo/Metallurgy-4-Reforged/blob/1.12.2/src/main/java/it/hurts/metallurgy_reforged/world/ModLakeWorldGen.java#L43

To Reproduce:

  1. Install Biomes O Plenty
  2. Install Metallurgy
  3. Enable Tar Pit generation (turn up frequency for effect)
  4. Watch the log complain during chunk generation

Expected behavior:
No logging errors, warnings or chunk runaway.

Environment Versions

Operating System: Windows 10
JVM: Java 8

Versions:

  • Metallurgy: 0.2.3
  • Conflicting mod (not at fault, just trips its debug logging): BoP 7.0.1+
  • Forge: 14.23.5.2847
  • Minecraft: 1.12.2
  • Modpack (if available): Crackpack 3

Logging Information

@Darkosto can provide you with examples if necessary but considering how much gets dumped to console it shouldn't be too difficult to see.