Metallurgy 4: Reforged

Metallurgy 4: Reforged

468k Downloads

Tinkers' Construct material will not show its localized name

DSLM opened this issue ยท 1 comments

commented

There is the screenshot of those material in Chinese language:
image
They were translated: https://github.com/Davoleo/Metallurgy-4-Reforged/blob/master/src/main/resources/assets/metallurgy/lang/zh_cn.lang#L2-L40

For the original materials Pigiron and Knightslime, it show correctly:
image

I guesses it caused by those code, which only read "material.%s.name" rather than "material.metallurgy.%s.name":
https://github.com/SlimeKnights/TinkersConstruct/blob/1.12/src/main/java/slimeknights/tconstruct/library/materials/Material.java#L40-L41
https://github.com/SlimeKnights/TinkersConstruct/blob/1.12/src/main/java/slimeknights/tconstruct/library/materials/Material.java#L434-L450

Maybe you can override getLocalizedName function?

commented

Should be fixed now, a really old method was manipulating the registry names to hardcode them in the book.
fixed
I've also added 2 new material name translations (Alduorite and Infuscolium) that were missing before, if you want to add those translations I'll gladly accept them (you can read the commit that closed this issue for information on the translation keys)