Gauging interest for survival-related pull requests from new maintainers
asanetargoss opened this issue · 4 comments
Is there interest from the new maintainers for survival-related pull requests into the 1.12 version of Metamorph?
The main benefit is players not having to choose between Changeling for survival improvements vs Metamorph for compatibility with various cinematic mods. The downside to you is additional maintenance burden involved in reviewing and merging the changes, as well as possible player expectation of survival features from the Metamorph team.
See this somewhat outdated page for a list of differences in the current Changeling release.
Regardless, I will continue to recommend Changeling for survival morphing, and I will continue to maintain the 1.11 and 1.10 branches for Changeling only as you probably don't have interest in those.
Hello,
I was wondering why the difference page says that you should use changelin if you want to submit pull requests. The mchorse mods are open for pull requests and there have been various official updates by others now. If you want to, you can make a pull request too for an official update. I will review the code and check if something peeks my eyes like GUI changes or so. And yeah I don't have interest in older mc versions... we can't maintain them, sorry. However, are you also willing to fix possible bugs created by your update then?
I was wondering why the difference page says that you should use changelin if you want to submit pull requests
Right, that page needs to be updated now that there are new maintainers.
And yeah I don't have interest in older mc versions... we can't maintain them, sorry.
That's fine. The older versions of Metamorph haven't been updated in a long time.
However, are you also willing to fix possible bugs created by your update then?
I am generally willing to assist in any issues which come up as a result of changes I introduce into the code.
It sounds like there is interest, then, in the changes being integrated upstream. I think the best approach would be for me to gradually open pull requests for each feature or group of related features. That will make review easier, and hopefully reduce merge conflicts later on. Also, there is no urgency for me in terms of when new Metamorph versions are released.