MidnightControls

MidnightControls

2M Downloads

Bug: Modded key bind doesn't show up on config screen if its translation key starts with "key."

NordAct opened this issue ยท 0 comments

commented

Describe the bug
Key binding added by mod may not be displayed on config screen by MidnightControls if translation key of a key bind starts with "key.". If key bind starts with anything but this, it does show up on config screen correctly

To Reproduce
Steps to reproduce the behavior:

  1. Find mod which does add key binds and translation keys for key binds start with "key." (i.e. this )
  2. Use open config screen and witness that there's no key binds for the mod in controller bindings section

Expected behavior
Modded key bindings would be automatically picked up by MidnightControls and displayed on config screen

Screenshots

Image

Desktop (please complete the following information):

  • OS: Ubuntu 24.04
  • Minecraft: 1.21.5
  • Modloader: Fabric Loader 0.16.12
  • Fabric/Quilt Libraries: Fabric Api 0.120.0+1.21.5
  • Mods: Geckolib 5.0, YACL 3.6.6+1.21.5, Useless Reptile in dev enviroment
  • Version: 1.11.0

Additional context
I've been getting complaints that key binds for my mod don't get picked up by MidnightControls for quite a while (1.21.5 version is not only one affected), but wasn't sure if I did something wrong with implementing them or it was something on MidnightControls side. I also tested it with other mod for controller support (Controlify) and it did display key binds from the mod on its config screen correctly.
Class with key binds in currently latest release of Useless Reptile (0.10.0-1.21.5): https://github.com/NordAct/useless-reptile/blob/2326acb4331f8941ce71b7d3c3994cab935d0322/src/main/java/nordmods/uselessreptile/client/init/URKeybinds.java#L11

As can be seen on screenshot, all key binds with translation keys that start with anything but "key." show up on config screen