Describe the bug
Repeated MIDI notes will not trigger Redstone output in Receivers.

To Reproduce
Steps to reproduce the behavior:

1. Create a MIDI file with repeated arbitrary notes on channel 1.
2. Program a Receiver to emit a signal on "Note Held" for the selected note(s); link the Receiver directly to the Transmitter; disallow all MIDI input except for channel 1.

Expected behavior
The given notes will trigger Redstone output from a programmed Receiver.

Screenshots

The notes highlighted do not incur output from a properly programmed Receiver.

Environment (please complete the following information):

• OS: Windows 10 22H2 Build 19045.5847
• Mod Version: 4.1.3
• Minecraft Version: 1.20.1
• Forge Version: 47.3.0

edit: more concise replication instructions

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

any updates on this issue?
i independently rediscovered this issue yesterday when it caused some tied notes to not play properly

in the meantime, the workaround i used was to put a gap between repeated notes by shortening one of them by a small amount (like a 64th rest)

Nope, nothing. I've had to do the same and it's really annoying.

tbh I mostly just replied to get rid of the "stale" label so hopefully tofodroid will be able to see this issue

Hello! Apologies for the very slow reply, I started a new job and things have been crazy so haven't had much time to work on MIMI. ☹️

I am trying to put together a list of things to look into fixing over this upcoming weekend though and this one caught my eye! If you have a moment would you mind uploading a MIDI file that exhibits the issue you're seeing? I think I understand the problem and how to fix it but want to make sure that I test with multiple files before calling it good.

Thank you and apologies again for the slow reply!

no problem; thank you anyways for taking the time to look at this issue
here's a basic midi file with two repeated middle Cs (C4): https://drive.google.com/file/d/1pg5FbXnxSD_h3VuhhUU8-ursxbqA1HrW/view?usp=sharing (can't directly upload midi files on github)

you can test it by first listening to the midi file hooked up to a grand piano (via transmitter or something similar) and then hook it up to a receiver with an LED cube. since there are two quarter notes back-to-back at 60 BPM, the cube should light up for 2 seconds, but it only lights up for 1 second, indicating the second note wasn't played at all.

if you need a video demonstration or anything else please let me know

incidentally, another weird thing i noticed is that for a C4 to be registered by a receiver, the receiver should actually be set to listen for a C5 instead (this is true for all notes. for a receiver to react to a note in the nth octave, it actually needs to be set to listen to the corresponding note in octave n+1. i am not sure if this is intended or not)

Hello! Thank you for the example MIDI file; That was very helpful! I was able to fix the issue so I'm hoping to have a new version of MIMI out including that fix in a day or so!

Re: The other issue you saw - If I remember correctly I did that intentionally because there doesn't seem to be a fully agreed-upon way to number the octaves in relation to MIDI notes (Example 1, Example 2, Example 3) so I believe I started with Octave 1 being at note A0, but I'll double check my math and confirm what I used. When I do confirm the numbering I used I'll try to put together a diagram like those I linked above specifically for MIMI's Octave numbering and include it somewhere in-game so that it's easy to find.

Hello! I've uploaded a beta version of the next release of MIMI for NeoForge 1.21.1 to Modrinth and CurseForge (CurseForge may take a few hours for it to be approved)!

I'll be working on back-porting the changes to Forge and the other supported versions of Minecraft over the next couple of days, but if you have some time please try out the beta and see if it helps out your issue!

Thanks for supporting MIMI! 😄

Hello! I've uploaded the latest full release of MIMI to Modrinth and CurseForge (CurseForge may take a few hours for it to be approved) which should address this issue!

Thanks for supporting MIMI! 😄