[Bug]: Default "datapack" causing errors.
zerafox opened this issue ยท 2 comments
Describe the bug you're experiencing
I've updated Mine and Slash to it's currently latest version: 5.9.9
When I login to the game I get a notice in chat about how there are errors with my Mine and Slash datapacks, some things may break.
Here is the errors the logs produced:[14:50:27] [Render thread/WARN]: ============[Mine and Slash Datapack Check Failed]================= [14:50:27] [Render thread/WARN]: The file with id epic is different after loading [14:50:27] [Render thread/WARN]: Json from your datapack: [14:50:27] [Render thread/WARN]: {"type":"NORMAL","affix_rarity_weight":500,"announce_in_chat":false,"can_have_runewords":false,"favor_loot_multi":1.15,"favor_needed":250,"favor_per_hour":0,"guid":"epic","higher_rar":"legendary","is_unique_item":false,"item_model_data_num":4,"item_tier":3,"item_tier_power":1.7,"item_value_multi":1.7,"lootable_gear_tier":"MID","map_lives":4,"map_resist_req":30,"map_reward":{"loot_multi":1.2,"loot_table":"mmorpg:chests/tier_3_dungeon","perc_to_unlock":70,"reward_chests":5},"map_tiers":{"max":60,"min":40},"map_xp_multi":1.05,"max_gems":10,"max_runes":1,"min_affixes":4,"min_lvl":25,"min_map_rarity_to_drop":"common","pot":{"total":50},"sockets":{"max":2,"min":0},"stat_percents":{"max":60,"min":40},"text_format":"LIGHT_PURPLE","vanilla_rar_enum":"EPIC","weight":100} [14:50:27] [Render thread/WARN]: Json after it was loaded and turned back into json: [14:50:27] [Render thread/WARN]: {"favor_needed":250,"favor_loot_multi":1.15,"favor_per_hour":0,"affix_rarity_weight":500,"type":"NORMAL","lootable_gear_tier":"MID","item_model_data_num":4,"stat_percents":{"min":40,"max":60},"pot":{"total":50},"min_affixes":4,"sockets":{"min":0,"max":2},"item_tier":3,"max_runes":1,"max_gems":10,"item_tier_power":1.7,"min_lvl":25,"min_map_rarity_to_drop":"common","item_value_multi":1.7,"announce_in_chat":false,"can_have_runewords":false,"is_unique_item":false,"map_tiers":{"min":40,"max":60},"map_lives":4,"map_xp_multi":1.05,"map_reward":{"perc_to_unlock":70,"loot_table":"mmorpg:chests/tier_3_dungeon","reward_chests":5,"loot_multi":1.2},"map_resist_req":30,"weight":100,"text_format":"LIGHT_PURPLE","higher_rar":"legendary","guid":"epic"} [14:50:27] [Render thread/WARN]: Please check for things like wrong field names, missing fields, wrong types used etc. [14:50:27] [Render thread/WARN]: You can copy and paste these jsons into any online Json Comparison/Diff tools see what the difference is. Like: www.jsondiff.com [14:50:27] [Render thread/WARN]: =================================================================== [14:50:27] [Render thread/WARN]: ============[Mine and Slash Datapack Check Failed]================= [14:50:27] [Render thread/WARN]: The file with id uncommon is different after loading [14:50:27] [Render thread/WARN]: Json from your datapack: [14:50:27] [Render thread/WARN]: {"type":"NORMAL","affix_rarity_weight":1000,"announce_in_chat":false,"can_have_runewords":false,"favor_loot_multi":1.05,"favor_needed":50,"favor_per_hour":60,"guid":"uncommon","higher_rar":"rare","is_unique_item":false,"item_model_data_num":2,"item_tier":1,"item_tier_power":1.25,"item_value_multi":1.25,"lootable_gear_tier":"LOW","map_lives":5,"map_resist_req":10,"map_reward":{"loot_multi":1.1,"loot_table":"mmorpg:chests/tier_1_dungeon","perc_to_unlock":50,"reward_chests":2},"map_tiers":{"max":20,"min":10},"map_xp_multi":1.0,"max_gems":10,"max_runes":1,"min_affixes":2,"min_lvl":0,"min_map_rarity_to_drop":"common","pot":{"total":10},"sockets":{"max":1,"min":0},"stat_percents":{"max":20,"min":10},"text_format":"GREEN","vanilla_rar_enum":"UNCOMMON_ITEM","weight":2000} [14:50:27] [Render thread/WARN]: Json after it was loaded and turned back into json: [14:50:27] [Render thread/WARN]: {"favor_needed":50,"favor_loot_multi":1.05,"favor_per_hour":60,"affix_rarity_weight":1000,"type":"NORMAL","lootable_gear_tier":"LOW","item_model_data_num":2,"stat_percents":{"min":10,"max":20},"pot":{"total":10},"min_affixes":2,"sockets":{"min":0,"max":1},"item_tier":1,"max_runes":1,"max_gems":10,"item_tier_power":1.25,"min_lvl":0,"min_map_rarity_to_drop":"common","item_value_multi":1.25,"announce_in_chat":false,"can_have_runewords":false,"is_unique_item":false,"map_tiers":{"min":10,"max":20},"map_lives":5,"map_xp_multi":1.0,"map_reward":{"perc_to_unlock":50,"loot_table":"mmorpg:chests/tier_1_dungeon","reward_chests":2,"loot_multi":1.1},"map_resist_req":10,"weight":2000,"text_format":"GREEN","higher_rar":"rare","guid":"uncommon"} [14:50:27] [Render thread/WARN]: Please check for things like wrong field names, missing fields, wrong types used etc. [14:50:27] [Render thread/WARN]: You can copy and paste these jsons into any online Json Comparison/Diff tools see what the difference is. Like: www.jsondiff.com [14:50:27] [Render thread/WARN]: =================================================================== [14:50:27] [Render thread/WARN]: ============[Mine and Slash Datapack Check Failed]================= [14:50:27] [Render thread/WARN]: The file with id legendary is different after loading [14:50:27] [Render thread/WARN]: Json from your datapack: [14:50:27] [Render thread/WARN]: {"type":"NORMAL","affix_rarity_weight":200,"announce_in_chat":true,"can_have_runewords":false,"favor_loot_multi":1.2,"favor_needed":500,"favor_per_hour":0,"guid":"legendary","higher_rar":"mythic","is_unique_item":false,"item_model_data_num":5,"item_tier":4,"item_tier_power":2.0,"item_value_multi":2.0,"lootable_gear_tier":"HIGH","map_lives":3,"map_resist_req":40,"map_reward":{"loot_multi":1.5,"loot_table":"mmorpg:chests/tier_4_dungeon","perc_to_unlock":80,"reward_chests":7},"map_tiers":{"max":80,"min":60},"map_xp_multi":1.1,"max_gems":10,"max_runes":1,"min_affixes":5,"min_lvl":40,"min_map_rarity_to_drop":"common","pot":{"total":75},"sockets":{"max":2,"min":1},"stat_percents":{"max":80,"min":60},"text_format":"GOLD","vanilla_rar_enum":"LEGENDARY_ITEM","weight":50} [14:50:27] [Render thread/WARN]: Json after it was loaded and turned back into json: [14:50:27] [Render thread/WARN]: {"favor_needed":500,"favor_loot_multi":1.2,"favor_per_hour":0,"affix_rarity_weight":200,"type":"NORMAL","lootable_gear_tier":"HIGH","item_model_data_num":5,"stat_percents":{"min":60,"max":80},"pot":{"total":75},"min_affixes":5,"sockets":{"min":1,"max":2},"item_tier":4,"max_runes":1,"max_gems":10,"item_tier_power":2.0,"min_lvl":40,"min_map_rarity_to_drop":"common","item_value_multi":2.0,"announce_in_chat":true,"can_have_runewords":false,"is_unique_item":false,"map_tiers":{"min":60,"max":80},"map_lives":3,"map_xp_multi":1.1,"map_reward":{"perc_to_unlock":80,"loot_table":"mmorpg:chests/tier_4_dungeon","reward_chests":7,"loot_multi":1.5},"map_resist_req":40,"weight":50,"text_format":"GOLD","higher_rar":"mythic","guid":"legendary"} [14:50:27] [Render thread/WARN]: Please check for things like wrong field names, missing fields, wrong types used etc. [14:50:27] [Render thread/WARN]: You can copy and paste these jsons into any online Json Comparison/Diff tools see what the difference is. Like: www.jsondiff.com [14:50:27] [Render thread/WARN]: =================================================================== [14:50:27] [Render thread/WARN]: ============[Mine and Slash Datapack Check Failed]================= [14:50:27] [Render thread/WARN]: The file with id rare is different after loading [14:50:27] [Render thread/WARN]: Json from your datapack: [14:50:27] [Render thread/WARN]: {"type":"NORMAL","affix_rarity_weight":750,"announce_in_chat":false,"can_have_runewords":false,"favor_loot_multi":1.1,"favor_needed":100,"favor_per_hour":0,"guid":"rare","higher_rar":"epic","is_unique_item":false,"item_model_data_num":3,"item_tier":2,"item_tier_power":1.5,"item_value_multi":1.5,"lootable_gear_tier":"MID","map_lives":5,"map_resist_req":20,"map_reward":{"loot_multi":1.2,"loot_table":"mmorpg:chests/tier_2_dungeon","perc_to_unlock":60,"reward_chests":3},"map_tiers":{"max":40,"min":20},"map_xp_multi":1.0,"max_gems":10,"max_runes":1,"min_affixes":3,"min_lvl":10,"min_map_rarity_to_drop":"common","pot":{"total":25},"sockets":{"max":1,"min":0},"stat_percents":{"max":40,"min":20},"text_format":"AQUA","vanilla_rar_enum":"RARE","weight":500} [14:50:27] [Render thread/WARN]: Json after it was loaded and turned back into json: [14:50:27] [Render thread/WARN]: {"favor_needed":100,"favor_loot_multi":1.1,"favor_per_hour":0,"affix_rarity_weight":750,"type":"NORMAL","lootable_gear_tier":"MID","item_model_data_num":3,"stat_percents":{"min":20,"max":40},"pot":{"total":25},"min_affixes":3,"sockets":{"min":0,"max":1},"item_tier":2,"max_runes":1,"max_gems":10,"item_tier_power":1.5,"min_lvl":10,"min_map_rarity_to_drop":"common","item_value_multi":1.5,"announce_in_chat":false,"can_have_runewords":false,"is_unique_item":false,"map_tiers":{"min":20,"max":40},"map_lives":5,"map_xp_multi":1.0,"map_reward":{"perc_to_unlock":60,"loot_table":"mmorpg:chests/tier_2_dungeon","reward_chests":3,"loot_multi":1.2},"map_resist_req":20,"weight":500,"text_format":"AQUA","higher_rar":"epic","guid":"rare"} [14:50:27] [Render thread/WARN]: Please check for things like wrong field names, missing fields, wrong types used etc. [14:50:27] [Render thread/WARN]: You can copy and paste these jsons into any online Json Comparison/Diff tools see what the difference is. Like: www.jsondiff.com [14:50:27] [Render thread/WARN]: =================================================================== [14:50:27] [Render thread/WARN]: ============[Mine and Slash Datapack Check Failed]================= [14:50:27] [Render thread/WARN]: The file with id mythic is different after loading [14:50:27] [Render thread/WARN]: Json from your datapack: [14:50:27] [Render thread/WARN]: {"type":"NORMAL","affix_rarity_weight":100,"announce_in_chat":true,"can_have_runewords":false,"favor_loot_multi":1.25,"favor_needed":1000,"favor_per_hour":0,"guid":"mythic","higher_rar":"","is_unique_item":false,"item_model_data_num":6,"item_tier":5,"item_tier_power":3.0,"item_value_multi":3.0,"lootable_gear_tier":"HIGH","map_lives":3,"map_resist_req":50,"map_reward":{"loot_multi":2.0,"loot_table":"mmorpg:chests/tier_5_dungeon","perc_to_unlock":90,"reward_chests":10},"map_tiers":{"max":100,"min":80},"map_xp_multi":1.25,"max_gems":10,"max_runes":1,"min_affixes":6,"min_lvl":50,"min_map_rarity_to_drop":"epic","pot":{"total":100},"sockets":{"max":2,"min":2},"stat_percents":{"max":100,"min":80},"text_format":"DARK_PURPLE","vanilla_rar_enum":"MYTHIC_ITEM","weight":25} [14:50:27] [Render thread/WARN]: Json after it was loaded and turned back into json: [14:50:27] [Render thread/WARN]: {"favor_needed":1000,"favor_loot_multi":1.25,"favor_per_hour":0,"affix_rarity_weight":100,"type":"NORMAL","lootable_gear_tier":"HIGH","item_model_data_num":6,"stat_percents":{"min":80,"max":100},"pot":{"total":100},"min_affixes":6,"sockets":{"min":2,"max":2},"item_tier":5,"max_runes":1,"max_gems":10,"item_tier_power":3.0,"min_lvl":50,"min_map_rarity_to_drop":"epic","item_value_multi":3.0,"announce_in_chat":true,"can_have_runewords":false,"is_unique_item":false,"map_tiers":{"min":80,"max":100},"map_lives":3,"map_xp_multi":1.25,"map_reward":{"perc_to_unlock":90,"loot_table":"mmorpg:chests/tier_5_dungeon","reward_chests":10,"loot_multi":2.0},"map_resist_req":50,"weight":25,"text_format":"DARK_PURPLE","higher_rar":"","guid":"mythic"} [14:50:27] [Render thread/WARN]: Please check for things like wrong field names, missing fields, wrong types used etc. [14:50:27] [Render thread/WARN]: You can copy and paste these jsons into any online Json Comparison/Diff tools see what the difference is. Like: www.jsondiff.com [14:50:27] [Render thread/WARN]: =================================================================== [14:50:27] [Render thread/WARN]: ============[Mine and Slash Datapack Check Failed]================= [14:50:27] [Render thread/WARN]: The file with id unique is different after loading [14:50:27] [Render thread/WARN]: Json from your datapack: [14:50:27] [Render thread/WARN]: {"type":"UNIQUE","affix_rarity_weight":1000,"announce_in_chat":true,"can_have_runewords":false,"favor_loot_multi":1.0,"favor_needed":0,"favor_per_hour":0,"guid":"unique","higher_rar":"","is_unique_item":true,"item_model_data_num":-1,"item_tier":5,"item_tier_power":2.0,"item_value_multi":2.0,"lootable_gear_tier":"HIGH","map_lives":5,"map_resist_req":50,"map_tiers":{"max":100,"min":0},"map_xp_multi":1.0,"max_gems":10,"max_runes":1,"min_affixes":0,"min_lvl":0,"min_map_rarity_to_drop":"common","pot":{"total":50},"sockets":{"max":2,"min":1},"stat_percents":{"max":100,"min":50},"text_format":"RED","vanilla_rar_enum":"UNIQUE_ITEM","weight":25} [14:50:27] [Render thread/WARN]: Json after it was loaded and turned back into json: [14:50:27] [Render thread/WARN]: {"favor_needed":0,"favor_loot_multi":1.0,"favor_per_hour":0,"affix_rarity_weight":1000,"type":"UNIQUE","lootable_gear_tier":"HIGH","item_model_data_num":-1,"stat_percents":{"min":50,"max":100},"pot":{"total":50},"min_affixes":0,"sockets":{"min":1,"max":2},"item_tier":5,"max_runes":1,"max_gems":10,"item_tier_power":2.0,"min_lvl":0,"min_map_rarity_to_drop":"common","item_value_multi":2.0,"announce_in_chat":true,"can_have_runewords":false,"is_unique_item":true,"map_tiers":{"min":0,"max":100},"map_lives":5,"map_xp_multi":1.0,"map_resist_req":50,"weight":25,"text_format":"RED","higher_rar":"","guid":"unique"} [14:50:27] [Render thread/WARN]: Please check for things like wrong field names, missing fields, wrong types used etc. [14:50:27] [Render thread/WARN]: You can copy and paste these jsons into any online Json Comparison/Diff tools see what the difference is. Like: www.jsondiff.com [14:50:27] [Render thread/WARN]: =================================================================== [14:50:27] [Render thread/WARN]: ============[Mine and Slash Datapack Check Failed]================= [14:50:27] [Render thread/WARN]: The file with id common is different after loading [14:50:27] [Render thread/WARN]: Json from your datapack: [14:50:27] [Render thread/WARN]: {"type":"NORMAL","affix_rarity_weight":1000,"announce_in_chat":false,"can_have_runewords":false,"favor_loot_multi":1.0,"favor_needed":0,"favor_per_hour":60,"guid":"common","higher_rar":"uncommon","is_unique_item":false,"item_model_data_num":1,"item_tier":0,"item_tier_power":1.0,"item_value_multi":1.0,"lootable_gear_tier":"LOW","map_lives":5,"map_resist_req":0,"map_reward":{"loot_multi":1.0,"loot_table":"mmorpg:chests/tier_1_dungeon","perc_to_unlock":0,"reward_chests":1},"map_tiers":{"max":10,"min":0},"map_xp_multi":1.0,"max_gems":10,"max_runes":1,"min_affixes":1,"min_lvl":0,"min_map_rarity_to_drop":"common","pot":{"total":5},"sockets":{"max":0,"min":0},"stat_percents":{"max":10,"min":0},"text_format":"GRAY","vanilla_rar_enum":"COMMON","weight":5000} [14:50:27] [Render thread/WARN]: Json after it was loaded and turned back into json: [14:50:27] [Render thread/WARN]: {"favor_needed":0,"favor_loot_multi":1.0,"favor_per_hour":60,"affix_rarity_weight":1000,"type":"NORMAL","lootable_gear_tier":"LOW","item_model_data_num":1,"stat_percents":{"min":0,"max":10},"pot":{"total":5},"min_affixes":1,"sockets":{"min":0,"max":0},"item_tier":0,"max_runes":1,"max_gems":10,"item_tier_power":1.0,"min_lvl":0,"min_map_rarity_to_drop":"common","item_value_multi":1.0,"announce_in_chat":false,"can_have_runewords":false,"is_unique_item":false,"map_tiers":{"min":0,"max":10},"map_lives":5,"map_xp_multi":1.0,"map_reward":{"perc_to_unlock":0,"loot_table":"mmorpg:chests/tier_1_dungeon","reward_chests":1,"loot_multi":1.0},"map_resist_req":0,"weight":5000,"text_format":"GRAY","higher_rar":"uncommon","guid":"common"} [14:50:27] [Render thread/WARN]: Please check for things like wrong field names, missing fields, wrong types used etc. [14:50:27] [Render thread/WARN]: You can copy and paste these jsons into any online Json Comparison/Diff tools see what the difference is. Like: www.jsondiff.com [14:50:27] [Render thread/WARN]: =================================================================== [14:50:27] [Render thread/WARN]: ============[Mine and Slash Datapack Check Failed]================= [14:50:27] [Render thread/WARN]: The file with id runeword is different after loading [14:50:27] [Render thread/WARN]: Json from your datapack: [14:50:27] [Render thread/WARN]: {"type":"RUNED","affix_rarity_weight":1000,"announce_in_chat":false,"can_have_runewords":true,"favor_loot_multi":1.0,"favor_needed":0,"favor_per_hour":0,"guid":"runeword","higher_rar":"","is_unique_item":false,"item_model_data_num":-1,"item_tier":10,"item_tier_power":2.0,"item_value_multi":2.0,"lootable_gear_tier":"HIGH","map_lives":5,"map_resist_req":50,"map_tiers":{"max":100,"min":0},"map_xp_multi":1.0,"max_gems":0,"max_runes":10,"min_affixes":0,"min_lvl":15,"min_map_rarity_to_drop":"common","pot":{"total":30},"sockets":{"max":6,"min":2},"stat_percents":{"max":0,"min":0},"text_format":"YELLOW","vanilla_rar_enum":"RUNED_ITEM","weight":150} [14:50:27] [Render thread/WARN]: Json after it was loaded and turned back into json: [14:50:27] [Render thread/WARN]: {"favor_needed":0,"favor_loot_multi":1.0,"favor_per_hour":0,"affix_rarity_weight":1000,"type":"RUNED","lootable_gear_tier":"HIGH","item_model_data_num":-1,"stat_percents":{"min":0,"max":0},"pot":{"total":30},"min_affixes":0,"sockets":{"min":2,"max":6},"item_tier":10,"max_runes":10,"max_gems":0,"item_tier_power":2.0,"min_lvl":15,"min_map_rarity_to_drop":"common","item_value_multi":2.0,"announce_in_chat":false,"can_have_runewords":true,"is_unique_item":false,"map_tiers":{"min":0,"max":100},"map_lives":5,"map_xp_multi":1.0,"map_resist_req":50,"weight":150,"text_format":"YELLOW","higher_rar":"","guid":"runeword"} [14:50:27] [Render thread/WARN]: Please check for things like wrong field names, missing fields, wrong types used etc. [14:50:27] [Render thread/WARN]: You can copy and paste these jsons into any online Json Comparison/Diff tools see what the difference is. Like: www.jsondiff.com [14:50:27] [Render thread/WARN]: ===================================================================
After some digging I found that these are files related to the new gear rarity datapacks added to the mod back in 5.9.0
No mod pack I use touches any of these values. So, I looked into the mod jar itself and found that these files actually still include the "vanilla_rar_enum": "UNCOMMON_ITEM", value that was said to be removed in 5.9.9.
I was still getting errors when I attempted to downgrade my MnS to 5.9.0 but got similar notices and errors.
Reproducability
Install Mine and Slash 5.9.0+ (or) 5.9.9 first and load into a world.
See chat based notice about datapack errors.
Mod up to date
- Before submitting this issue I updated to the newest version and reproduced it
Tested Without Custom Mine and Slash Datapacks
- In case I used Mine and Slash datapacks, I ran Mine and Slash in a new instance without custom datapacks and confirmed the bug still exists
Mine and Slash version
5.9.9
Logs
https://gist.github.com/zerafox/a9607683141d70722c54382b087692ef
