Mine and Slash

Mine and Slash

3M Downloads

[Bug]: vuln_crit stat is not working

adfa0107 opened this issue · 2 comments

commented

Describe the bug you're experiencing

I applied the physical_vuln_crit stat
화면 캡처 2024-12-30 223818

So I expected the basic attack and skill damage to come up as critical damage, but no critical applied
화면 캡처 2024-12-30 223831
화면 캡처 2024-12-30 223955

Other vuln_cirt statistics were not applied either

Reproducability

It happens when the physical_vuln_crit stat is applied as a command. No other method has been tested

Mod up to date

  • Before submitting this issue I updated to the newest version and reproduced it

Tested Without Custom Mine and Slash Datapacks

  • In case I used Mine and Slash datapacks, I ran Mine and Slash in a new instance without custom datapacks and confirmed the bug still exists

Mine and Slash version

Mine_and_Slash-1.20.1-5.9.37

Logs

https://gist.github.com/adfa0107/104b1f8db6c20da3533bfc798450d7d6

commented

that stat is about making you always take dmg as crits, not you dealing crits

commented

Sorry for opening issue without understanding the feature, thank you for your response.