MineColonies

MineColonies

59M Downloads

[BUG] Removing recipes that are Built-In on a hut might either crash or reset the whole list

AylanJ123 opened this issue ยท 2 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues

Are you using the latest MineColonies Version?

  • I am running the latest beta version of MineColonies for my Minecraft version.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • Single Player
  • Multi Player

Minecraft Version

1.20.1

MineColonies Version

1.1.601-BETA

Structurize Version

1.0.738-BETA

Related Mods and their Versions

Forge 47.2.23

Current Behavior

When removing recipes in a quick succesion (which are built in like the copper state recipes on the Mechanic) might crash the client with an OutOfBounds exception or might clean the whole recipe list.

Expected Behavior

Removing recipes that are built in should:

  • Not be allowed (Grey button)
  • Not work (Just doesn't get removed)
  • Keep the current behaviour of coming back after a couple seconds but shouldn't crash or reset when doing it

Reproduction Steps

  1. Make a multiplayer world (Couldn't get it to happen on single player maybe because the laptop is faster than the server on Single Player.
  2. Add some recipes along with the default ones (Easier to test on a lvl 1 Mechanic).
  3. Remove them quickly and there is a chance for any of both situations to happen.

Logs

https://mclo.gs/ZwgeCOb

Anything else?

Couldn't get it to happen on a clean install, maybe because I tested on Single Player.

commented

same issue as ldtteam/BlockUI#93 closing in favor of that one

commented

Both bugs happen on BlockUI, might be related to ldtteam/BlockUI#93