Is there an existing issue for this?

• I have searched the existing issues.

Are you using the latest MineColonies Version?

• I am running the latest beta/release version of MineColonies for my Minecraft version.
  I am also running the latest versions of other mods that are part of my problem.

Did you check on the Wiki? or ask on Discord?

• I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

• Single Player
• Multi Player

Minecraft Version

1.20

MineColonies Version

1.20.1-1.1.697-snapshot

Structurize Version

1.20.1-1.1.697-snapshot

Related Mods and their Versions

Current Behavior

I asked on discord why it wasn't translated into Spanish when you found an abandoned colony and where I could help to translate, since I understand English perfectly. I checked the wiki and saw that the translation to Spanish was at 100%. Then on discord they told me that it wasn't set to translate and that I should create an incident and that's what I do.

As I've been playing, I've realized that the tutorial that the settler gives you to play or when you set up your settlement isn't translated either.

Expected Behavior

Reproduction Steps

I would like the stories, the tutorial and the campsite to be content that we could translate.
I would be happy to do it in Spanish.

Thank you in advance.

Logs

Anything else?

--

Footer

Viewers

• Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
• Add a comment if you have any insights or background information that isn't already part of the conversation.

Some quests are uploaded, but it doesn't look like any of the tutorial ones are there.

Edit: Nevermind, there are 7 full pages, the tutorial quests are translated as well. So it's more likely an issue in the code if they're not getting translated.

The upload is semi up-to-date, it's only ever since GH actions it's not uploading, which is an easy fix, but still the majority of translations should work.

The quests should be translatable though @uecasm and maybe @Thodor12 for the wrong lang file being uploaded (pre merger)

Quests, yes. Stories, not yet 😛

Stories are fixed content, we should make them datagen an array of strings for translation purposes

I guess the crowdin upload task has no dependency on mergeTranslations. Locally the file is filled properly with all quests.

Oh, we're not calling the upload at all :)

@Raycoms The generated quests file do not use the translation values, instead they just use the raw values:
Quest file:

{
  "name": "A roof over the head",
   "objectives": [
    {
      "type": "minecolonies:dialogue",
      "target": 0,
      "text": "Hi there! Your builder is looking neat! How about we let them build a Tavern so that your citizens don't have to sleep outside and are safe at night?",
}

Quest translations:

  "minecolonies.quests.tutorial.tavern": "A roof over the head",
  "minecolonies.quests.tutorial.tavern.obj0": "Hi there! Your builder is looking neat! How about we let them build a Tavern so that your citizens don't have to sleep outside and are safe at night?",

Main, the quests themselves are hardcoded and then generate translations for them, but those translations are never persisted back into the actual quest file.

We're probably going to have to make the quest templates come from datagen themselves if we want to fill the translation string + actual translation

Is that from the main resources or from the generated resources?

Hmm, they do look good in datagen, is it possible that main is taking precedence over datagen?

It doesn't override the actual quest site, it's generated into the datagen folder quest files.

Shouldn't, are these strings all uploaded to crowdin?

File in the jar:

Translation on Crowdin:

Could be possible what I stated on Discord, because crowdin was never rebuilding the translation files and using cached data it might've never actually generated?

@sukispring All translations (not just Spanish) are fixed in version 704. So at least the quests should start being translated now.

@sukispring You may also look on crowdin to translate any additional strings that have been newly uploaded.
Also Ray noticed there are faulty texts in other content, if you want/have time you may also look over any existing content to see if it's correct.

I'll close this and refer you to the feature request repo for the translation requests

Lets goo! Thank you so much