MineColonies

MineColonies

61M Downloads

When the config option "Show colony borders in team color" (colonyteamborders) is enabled, selecting the build tool crashes the game

EeveeKnowsBest opened this issue ยท 1 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues.

Are you using the latest MineColonies Version?

  • I am running the latest beta/release version of MineColonies for my Minecraft version.
    I am also running the latest versions of other mods that are part of my problem.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • Single Player
  • Multi Player

Minecraft Version

1.20

MineColonies Version

minecolonies-1.20.1-1.1.789-snapshot

Structurize Version

structurize-1.20.1-1.0.763-snapshot

Related Mods and their Versions

NeoForge v47.1.106
Embeddium v0.3.31
Embeddium++ v1.2.13
Oculus v1.8.0
Journeymap 5.10.3

Current Behavior

After a colony is instated, and the town hall is built, and after editing the colony color, attempting to select the build tool crashes the game with a com.minecolonies.core.client.render.worldevent.ColonyBorderRenderer.lambda$draw$1(ColonyBorderRenderer.java:156) error

Disabling the "Show colony borders in team color" option in the config file fixes this, and re-enabling it causes the client to crash again.

Expected Behavior

Build tool should have been selected and rendered the colony border grid properly without crashing

Reproduction Steps

Set down a supply camp
Take the build tool and town hall from the supply chest
Set up the initial phase of the town hall
Activate town hall and customize flag
Customize "Colony color"
Exit the town hall menu and attempt to select the build tool again

Logs

https://gist.github.com/EeveeKnowsBest/e458ef1875bfcbfd8dd73465f90a5eeb

Anything else?

Many mods are at play here, I don't really know if it's a specific conflict with mods or not, but doing my own testing over and over and asking around in the discord server didn't help us pinpoint the exact source outside some sort of a rendering issue with the colored colony team borders.
I initially attempted to try to find a config option to disable rendering the colony's border grid, but didn't spot such an option, so I instead disabled the colony team border color config option and lo and behold the crashing has stopped.

Footer


Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.
commented

This works fine with Minecolonies and dependencies alone, so it's likely one of your other mods that's doing something weird. I've looked at the code in question and while I can see why it'd crash at that point if the value was null, I can't see any good reason why the value would be null at that point.

On the Discord, type !binarysearch into the #bot-commands channel and try doing what it says (in a separate instance so that it doesn't disrupt your regular one) to try to identify the culprit.