MineColonies

MineColonies

61M Downloads

Warehouse sort can modify items.

KS-HTK opened this issue ยท 1 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues.

Are you using the latest MineColonies Version?

  • I am running the latest beta/release version of MineColonies for my Minecraft version.
    I am also running the latest versions of other mods that are part of my problem.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • Single Player
  • Multi Player

Minecraft Version

1.21

MineColonies Version

1.1.820-1.21.1-snapshot

Structurize Version

1.0.758-1.21.1-snapshot

Related Mods and their Versions

Any mod that has some sort of Data present on Items.

I was playing Direwolf20's Pack

Current Behavior

When you have some Items with custom data (Just Dire Things Fuel Canister, EvilCraft Brooms, Minecraft Spawners) on a Rack and use the sort function of the Warehouse (I've only tested lv.3) the Items get stacked (if possible) and custom data gets lost.
For the 'Just Dire Things' Fuel canister this allows duplicating/destroying fuel.
For the brooms of EvilCraft this changes all of them to the same version with the same charge.
For Minecraft (or EnderIO) Spawners this will stack them and they will all be converted to the same type.

This can be very annoying if you're looted speedy broom is suddenly gone, which is what happend to me on a Server.
Attached are some screenshots of before and after sorting in a Creative Test world.

Image
Image
Image

Expected Behavior

Not modify Items?!

Reproduction Steps

  1. Get two Items that are the same ID (e.g. minecraft:spawner) but have additional date (the mob they spawn)
  2. Add them to a warehouse rack of a lv. 3 warehouse
  3. Sort the warehouse stock
  4. Observe the modified Items

Logs

None

Anything else?

No response

Footer


Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.
commented

This can totally be used if wanted to duplicate energy with the fuel canister, my screenshots show them both empty, but if one knows the sequence of the racks they can be placed such that they end up both full. (I have not tested this further but from the three times I observed it, it seems to behave deterministically.)