MineColonies

MineColonies

Mods
65M Downloads

Guards not accepting bows, foresters not accepting shears

JBurlison opened this issue ยท 3 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues.

Are you using the latest MineColonies Version?

  • I am running the latest beta/release version of MineColonies for my Minecraft version.
    I am also running the latest versions of other mods that are part of my problem.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • Single Player
  • Multi Player

Minecraft Version

1.20

MineColonies Version

1.1.814

Structurize Version

1.0.10

Related Mods and their Versions

Current Behavior

Asks for shears
Image

Given multiple types of them:

Image

Expected Behavior

Should do work and not error saying they dont have them

Reproduction Steps

  1. observe icon
  2. right click to talk to citizen
  3. aknowlage they need shears.
  4. go tto open requests tab and click fulfill
  5. confirm they now have the item

Logs

https://gist.github.com/JBurlison/5cc2595b1bb333f0bc36e821b0386d18

Anything else?

No response

Footer

Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.
commented

From your logs:

Image

We can't help with that mod installed sorry

commented

Compatibility issue with No Durability Mod.
It goes without saying, it should not works if this mod installed.

Image

minecolonies/src/main/java/com/minecolonies/api/equipment/ModEquipmentTypes.java

Lines 222 to 230 in 62cfd2c

public static int durabilityBasedLevel(ItemStack itemStack, int vanillaItemDurability)
{
if (!itemStack.isDamageableItem())
{
return 5;
}
return Math.min(itemStack.getMaxDamage() / vanillaItemDurability, 5);
}

commented

Thank you for the help!

In case anyone comes across this in the future here is a mod that does work with minecolonies.
https://www.curseforge.com/minecraft/mc-mods/what-durability