Is there an existing issue for this?

• I have searched the existing issues.

Are you using the latest MineColonies Version?

• I am running the latest beta/release version of MineColonies for my Minecraft version.
  I am also running the latest versions of other mods that are part of my problem.

Did you check on the Wiki? or ask on Discord?

• I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

• Single Player
• Multi Player

Minecraft Version

1.21

MineColonies Version

1.1.895

Structurize Version

1.0.763

Related Mods and their Versions

1. Neoforge 21.1.132
2. 1.0.195
3. 1.0.204

Current Behavior

Trying to place a colony, But keep getting the problem of "no space" but the area is completely clear. Theres nothing blocking it.

Expected Behavior

Colonists to spawn around the town hall.

Reproduction Steps

1. Place town hall.
2. Place builder's hut.
3. Message appears and no colonists.

Logs

https://pastebin.com/7APT8jNL

Anything else?

No response

Footer

Viewers

• Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
• Add a comment if you have any insights or background information that isn't already part of the conversation.

Is your townhall hutblock up in the air, or underground?

If it is underground, you need to make space, if it is in the air, you need to make a platform around the town hall hutblock and stairs for them to get down to the ground

I've had it on the ground, like. sat on the dirt, and ive had it floating up by one block. Both times it complained there wasn't space.

This is the problem.

What position is the position it is telling you? Is that the block itself or next to it

it's telling me the town all block itself.

Still having this problem on the latest version.
I'm using the colonial build style.

Apologees, I don't get notifs for github. I'll do it tomorrow if that's oki <3

Oki. Seems like it could be a problem with one of my mods. Cause now it works in a new world.

It would be very useful if you could find out which mod causes this =D

I shall try my best <3 Or would you guys like the modpack and to try yourselves aswell?

(side note, when I had all the mods enabled. the medievel oak building style worked)

The issue was with Structurize solid block detection. In AnimalPens I had a code that prevented placing things directly above Aquariums. The detection involved checking the block below from the input position; however, Structurize used canSurvive method with null as parameters, resulting in failing all blocks, as they run into null-pointer exception, which they did not report anywhere, and just marked all blocks as non-valid for spawning.
BlockUtils#canBlockSurviveWithoutSupport

I was not expecting that these parameters could be null, so did not have null-pointer check. The issue is fixed in AnimalPens 1.4.2 version.

Looking at the animal pen code its a bit odd of a choice aswell, you shouldnt be using mixins there.
Either I'd implement it within the neighbour update callback of the aquarium or you should be using the forge/neoforge block placement events

Hello, I also have this problem, here are logs with list of mods I use (craftoria modpack with minecolonies added by me) https://pastebin.com/cYEbSXQK

Similarly to Ten-jen I found out that other building styles worked. More specifically, alttownhalls form oak and spruce medieval packs generate this problem, default townhalls from these packs work correctly.

Cos I have migraine brain, and became hyper focused, I compared both modlists, installed all the common ones, then did a binary search (ish, I turned off about 15-20 at a time because curseforge was so damned slow to turn them off).

Just as an aside, because I am me, and for some reason when it comes to lists of things, I start at the bottom, of COURSE the mod was right at the freaking top of the list!

Anyways, Animal Pens is the mod causing citizens to not spawn. I'll add it to the incompat list on discord.

Are you guys able to work out from the logs above what the actual problem is so we can report it to them?

Animal Pens is the issue

I just had the error where we combined CRAFTORIA modpack with Minecolonies and the NPCS would not spawn with the error there's not enough space but upon disabling Animal Pens it worked

Thanks to ShindRaya on Discord for aiding in solving the issue!

Probably related.