Assistant Hammer's area clear is too restrictive
Closed this issue ยท 1 comments
Is there an existing issue for this?
- I have searched the existing issues.
Are you using the latest MineColonies Version?
- I am running the latest beta/release version of MineColonies for my Minecraft version.
I am also running the latest versions of other mods that are part of my problem.
Did you check on the Wiki? or ask on Discord?
- I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.
What were you playing at the time? Were you able to reproduce it in both settings?
- Single Player
- Multi Player
Minecraft Version
1.20
MineColonies Version
1.20.1-1.1.924-snapshot
Structurize Version
1.20.1-1.0.773-snapshot
Related Mods and their Versions
Forge 47.4.0
DO 1.20.1-1.0.285-snapshot
Current Behavior
Using the Assistant Hammer (any material, Iron Gold or Diamond all the same) works fine on tier 1 buildings; however once the building is complete and you go to upgrade, the hammer becomes effectively useless. Every swing returns the error "You need to wait until the Builder finishes clearing the area" - even if you right-click the exact block/area the builder is currently working in, and even if it is actually clear.
Expected Behavior
I'm not sure what the best behavior is here and I'll leave that up to others.
Reproduction Steps
- Start constructing any tier 1 structure
- Equip an Assistant Hammer
- Make sure area is clear
- Help builder, it should work
- Once building is complete, upgrade and repeat step 4, it should not work
Logs
n/a
Anything else?
Overall the check for "is the area clear enough to allow the hammer to work" is a bit too restrictive; it seems (I haven't looked at the code and probably couldn't if I tried) but it seems to check for any foreign blocks not matching the schematic inside the build zone and if it finds even one it says no.
Footer
Viewers
- Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
- Add a comment if you have any insights or background information that isn't already part of the conversation.
