MineColonies

MineColonies

65M Downloads

RequestSystem restaurant

Closed this issue · 2 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues.

Are you using the latest MineColonies Version?

  • I am running the latest beta/release version of MineColonies for my Minecraft version.
    I am also running the latest versions of other mods that are part of my problem.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • Single Player
  • Multi Player

Minecraft Version

1.21

MineColonies Version

1.1.943-1.21.1

Structurize Version

1.0.767-1.21.1

Related Mods and their Versions

No response

Current Behavior

The restaurant always generates a single “batch” request of 16 food items. If the cook only has 15 items available, they will refuse to start cooking until the full 16 are delivered. In practice this means:

A citizen gathers up to 15 items (if that’s all they have) but never fulfills the request.

The restaurant never receives food because its request never exactly matches 16.

Citizens wind up hungry or stuck holding resources indefinitely.

Gameplay grinds to a halt whenever food stocks drop below that hard‑coded threshold.

This behavior makes the restaurant unusable on servers with limited automation or partial restocking, and forces every colony to maintain large food reserves.

Steps to reproduce:

Create a colony with a level ≥1 restaurant.

Allow the citizen cook to generate a food request (you’ll see “16× cooked beef,” etc.).

Provide the cook with only 15 of the requested item.

Observe that the cook refuses to start and never updates the request or retries with the 15 items on hand.

Expected behavior:

The restaurant should accept any positive quantity of the requested item, or at minimum allow the batch size to be configured in config/minecolonies/*.toml.

With a setting like restaurantBatchSize = 1, the restaurant would generate requests of 1 item at a time, ensuring that a single delivered resource is consumed immediately rather than waiting for a full 16.

Actual behavior:

Batch size is hard‑coded to 16 in RequestBuilder (or equivalent), with no exposed config.

Citizens will never deliver a partial batch and the restaurant stalls permanently below that threshold.

Suggested fix:

Expose a new config option under [requestsystem], e.g.

Max number of items per restaurant request

restaurantBatchSize = 1 # default: 16

Update the RequestSystem code to use this value instead of the hard‑coded 16.

Additional information:

A datapack workaround (overriding data/minecolonies/requestsystem/restaurant_requests.json) may be possible, but a native config option is far more user‑friendly.

This issue affects all versions where the batch size remains unconfigurable (tested on 1.21.1/NeoForge).

Expected Behavior

s

Reproduction Steps

s

Logs

s

Anything else?

No response

Footer

s

commented

This has been fixed already a while ago. You are using an old version of the mod and you should update your mods accordingly.

Fixed in version minecolonies-1.1.989-1.21.1 to be more precise, here is the pull:
#10922

commented

my bad. Thx