Recruitement items has non-stackable items requiring more than player inventory space
Closed this issue ยท 2 comments
Is there an existing issue for this?
- I have searched the existing issues.
Are you using the latest MineColonies Version?
- I am running the latest beta/release version of MineColonies for my Minecraft version.
I am also running the latest versions of other mods that are part of my problem.
Did you check on the Wiki? or ask on Discord?
- I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.
What were you playing at the time? Were you able to reproduce it in both settings?
- Single Player
- Multi Player
Minecraft Version
1.20
MineColonies Version
minecolonies-1.20.1-1.1.976.jar (custom branch from this version)
Structurize Version
structurize-1.20.1-1.0.772-snapshot.jar
Related Mods and their Versions
No response
Current Behavior
For a level 1 tavern building, the recruitment cost of a visitor resulted in a 42 beetroot soup need. As the item doesn't stack, I cannot fit more than (4x7) 28 beetroot soup in my inventory to recruit the visitor.
From the source code file, the calculation seems to be correct for stackable items.
~15 multiplied by rarity of (2+1)
Expected Behavior
Non-stackable items have their cost somewhat divided by ~5 maybe, or they are removed from the recruitment json list or replaced by some other stackable items.
Reproduction Steps
Review the visitors recruitment costs on a tavern level 1.
Logs
Anything else?
Footer
Viewers
- Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
- Add a comment if you have any insights or background information that isn't already part of the conversation.
correction: 9 items per row x 4 rows = 36 available inventory slots for items recruitment
