
JEI not showing hut recipe tabs
Corbi84 opened this issue · 3 comments
Is there an existing issue for this?
- I have searched the existing issues.
Are you using the latest MineColonies Version?
- I am running the latest beta/release version of MineColonies for my Minecraft version.
I am also running the latest versions of other mods that are part of my problem.
Did you check on the Wiki? or ask on Discord?
- I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.
What were you playing at the time? Were you able to reproduce it in both settings?
- Single Player
- Multi Player
Minecraft Version
1.21
MineColonies Version
1.1.1099-1.21.1
Structurize Version
1.0.787-1.21.1
Related Mods and their Versions
FTB Skies 2modpack, version 1.7.0
Current Behavior
Similar to this issue #8333 the recipe tabs for the different huts don't show up in JEI.
Expected Behavior
Tabs to be visible in JEI:
Reproduction Steps
Install FTB Skies 2, add Minecolonies & dependencies, fire it up and check JEI.
I do hope that the log gives you the necessary answers, though. ;-)
Logs
https://gist.github.com/Corbi84/f530cf5ec563449630f8ecf851bb1584
Anything else?
Additional comment from MotionlessTrain (might save some time searching):
From what I can see, there is a tool in the modpack that has some weird durability, or something like that. It tries to find out what building level is needed for that item, and apparently resorts to durability to do so. During the calculation, it somehow divides by 0
!github Could you make a GitHub issue about that? I’m not sure whether it just prints a log and managed to continue, ignoring that tool, or whether it messes other things up. But this doesn’t look like intended to me
Footer
Viewers
- Add a 👍 reaction to the bug report if you are also affected. This helps the bug report become more visible without cluttering the comments.
⚠️ Only add a comment if you have new insights or background information not already mentioned. Off-topic or "+1" comments will be deleted to keep the discussion focused.
java.lang.ArithmeticException: / by zero
at TRANSFORMER/[email protected]/com.minecolonies.api.equipment.ModEquipmentTypes.durabilityBasedLevel(ModEquipmentTypes.java:216) ~[minecolonies-1.1.1099-1.21.1-snapshot.jar%23881!/:1.1.1099-1.21.1-snapshot]
at TRANSFORMER/[email protected]/com.minecolonies.api.equipment.ModEquipmentTypes.lambda$static$21(ModEquipmentTypes.java:117) ~[minecolonies-1.1.1099-1.21.1-snapshot.jar%23881!/:1.1.1099-1.21.1-snapshot]
at TRANSFORMER/[email protected]/com.minecolonies.api.equipment.registry.EquipmentTypeEntry.getMiningLevel(EquipmentTypeEntry.java:128) ~[minecolonies-1.1.1099-1.21.1-snapshot.jar%23881!/:1.1.1099-1.21.1-snapshot]
at TRANSFORMER/[email protected]/com.minecolonies.core.colony.crafting.ToolsAnalyzer.tryAddingToolWithLevel(ToolsAnalyzer.java:87) ~[minecolonies-1.1.1099-1.21.1-snapshot.jar%23881!/:1.1.1099-1.21.1-snapshot]
at TRANSFORMER/[email protected]/com.minecolonies.core.colony.crafting.ToolsAnalyzer.findTools(ToolsAnalyzer.java:40) ~[minecolonies-1.1.1099-1.21.1-snapshot.jar%23881!/:1.1.1099-1.21.1-snapshot]
at TRANSFORMER/[email protected]/com.minecolonies.core.compatibility.jei.ToolRecipeCategory.findRecipes(ToolRecipeCategory.java:54) ~[minecolonies-1.1.1099-1.21.1-snapshot.jar%23881!/:1.1.1099-1.21.1-snapshot]
at TRANSFORMER/[email protected]/com.minecolonies.core.compatibility.jei.JEIPlugin.onRecipesLoaded(JEIPlugin.java:189) ~[minecolonies-1.1.1099-1.21.1-snapshot.jar%23881!/:1.1.1099-1.21.1-snapshot]
Yeah, looks like some mod is changing the max damage of the vanilla tools to 0. That mod needs to be shot (or at least removed from your pack). Then things should behave.
I'm not sure it's useful adding defensive code on our side to prevent the exception; this sort of change breaks a lot of fundamental assumptions about how tools work and should probably just be treated as incompatible.
Got any way to narrow down what might causing tools to be able to have a 0 durability? And does it only effect vanilla tools?
Trying to find a solution in parallel on the FTB-discord and they said, if it's pack-specific (since mods like MystialAgriculture, Just Dire Things or Silent Gear run fine alongside MCol in other packs), the answer would probably lie in either datapacks or kubejs.
It's most likely to be something that deliberately makes vanilla tools useless in order to promote their fancier tools. Packs that included Tinkers used to do this a lot (though Tinkers itself did not). You can try doing a binary search if that doesn't help narrow it down (just use a sacrificial world/instance).