Hardcoded tags
AlmanaX-21 opened this issue · 4 comments
Is there an existing issue for this?
- I have searched the existing issues.
Are you using the latest MineColonies Version?
- I am running the latest beta/release version of MineColonies for my Minecraft version.
I am also running the latest versions of other mods that are part of my problem.
Did you check on the Wiki? or ask on Discord?
- I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.
What were you playing at the time? Were you able to reproduce it in both settings?
- Single Player
- Multi Player
Minecraft Version
1.21
MineColonies Version
1.1.1099
Structurize Version
1.0.787
Related Mods and their Versions
No response
Current Behavior
On latest ATM 10 release, I have been looking at a bug which causes a dupe with interactions between Minecolonies and Regions unexplored. The error is hard to fix since you guys hard code tags thru code which cannot be removed.
When I attempted to remove the tag, it just does not work.
allthemods.add('test:testing', 'regions_unexplored:raw_redstone_block')
allthemods.remove('minecolonies:breakable_ore', 'regions_unexplored:raw_redstone_block')
Expected Behavior
Tags should be removable easily. Using datapacks I believe is the new method for handling tags.
Reproduction Steps
Logs
Anything else?
Footer
Viewers
- Add a 👍 reaction to the bug report if you are also affected. This helps the bug report become more visible without cluttering the comments.
⚠️ Only add a comment if you have new insights or background information not already mentioned. Off-topic or "+1" comments will be deleted to keep the discussion focused.
They can be removed via a datapack
It is possible to replace everything in a tag with { replace: true } in the file (and the new block items)
Does your remove method support indirect removals? Because the breakable_ore tag doesn't include that block directly, but only indirectly through another tag. You may need to remove it from the other tag instead.
As Train said, though, we recommend using datapacks rather than scripting, especially since 1.21 introduced a removal system for tags so that you don't need to do a full replace.