MineColonies

MineColonies

65M Downloads

Hurt Visitors settings doesn't work by its own

pwaksman973 opened this issue · 0 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues.

Are you using the latest MineColonies Version?

  • I am running the latest beta/release version of MineColonies for my Minecraft version.
    I am also running the latest versions of other mods that are part of my problem.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • Single Player
  • Multi Player

Minecraft Version

1.21

MineColonies Version

minecolonies-1.1.1121-1.21.1-snapshot

Structurize Version

structurize-1.0.787-1.21.1-snapshot

Related Mods and their Versions

No response

Current Behavior

In summary, the Hurt Visitor settings seems to not be looking for the Hurt Visitor, but Attack Entity instead.
Turning Hurt visitors on and off doesn't do anything at all.

Image

Expected Behavior

Hurt Visitors should look to Hurt Visistor flag.

Having to disable Attack entity also prevent us from dealing with other peask things like the wandering trader, as with Attack Entity off, the Wandering trader is also "immunized" while inside the colony.

Like the Hurt Citizen flag, that works as one would expect, turning it off prevent the "accidental" hitting of a citizen when fighting other mobs, regardless the other settings.

Reproduction Steps

Have some colony with some visitors

On the settings, as a owner, for the owner section:

  1. turn off Hurt Visitors
  2. punch a visitor, they take damage.
  3. turn off attack entity
  4. punch a visitor, permission message sent on chat, visitor does not take damage.
  5. turn on Hurt Visitor
  6. punch a visitor, permission message sent on chat, visitor does not take damage.

Logs

https://gist.githubusercontent.com/pwaksman973/84d4fbe2264580a03dd40d474a02e18a/raw/1109a495ae6e4d8c8cfecc8e60684b5d7e457fb4/gistfile1.txt

Anything else?

No response

Footer


Viewers

  • Add a 👍 reaction to the bug report if you are also affected. This helps the bug report become more visible without cluttering the comments.
  • ⚠️ Only add a comment if you have new insights or background information not already mentioned. Off-topic or "+1" comments will be deleted to keep the discussion focused.