Workers get stuck when buildings have partial ingredients - don't request remaining items needed
haggbart opened this issue · 3 comments
Is there an existing issue for this?
- I have searched the existing issues.
Are you using the latest MineColonies Version?
- I am running the latest beta/release version of MineColonies for my Minecraft version.
I am also running the latest versions of other mods that are part of my problem.
Did you check on the Wiki? or ask on Discord?
- I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.
What were you playing at the time? Were you able to reproduce it in both settings?
- Single Player
- Multi Player
Minecraft Version
1.20
MineColonies Version
v1.20.1-1.1.1072 hotfix #11283
Structurize Version
1.20.1-1.0.782-snapshot
Related Mods and their Versions
Default setup (runClient) commit hotfix #11283 dcd642c
Current Behavior
Workers become permanently stuck when their building contains a partial amount of ingredients needed for crafting. The worker picks up the partial items into their inventory but never requests the remaining quantity needed to complete the recipe.
Example 1 - Chef:
- Recipe requires 16 eggs
- Building has 8 eggs in storage
- Chef picks up the 8 eggs
- Chef stuck forever - never requests the remaining 8 eggs
Example 2 - Carpenter:
- Request for bowls (requires oak planks)
- Building has partial stack of oak planks (less than recipe needs)
- Carpenter picks up the planks
- Carpenter stuck forever - never requests remaining planks to meet minimum requirement
Expected Behavior
Workers should request the remaining items needed after accounting for what's already in their inventory
Reproduction Steps
- Set up a Chef building with an active crafting request (eg. Fried Rice)
- Manually place exactly 8 eggs in the Chef's building storage (half of what's needed for 16-count recipe)
- Wait for the Chef to pick up the 8 eggs into their personal inventory
- Observer: Chef will be stuck indefinitely, never requesting the remaining 8 eggs needed
Request from restaurant:
Chef's inventory:
/mc colony requestsystem-reset-all
Causes new request for 16 eggs (not 8), and gets stuck again later.
Alternative reproduction:
- Set up a Carpenter with a bowl crafting request
- Place a partial amount of oak planks in the Carpenter's building (less than the recipe requires)
- Carpenter picks up the partial planks
- Carpenter gets stuck, never requesting the rest
Chef's request:
Carpenter's inventory:
Logs
Nothing relevant
Anything else?
Footer
Viewers
- Add a 👍 reaction to the bug report if you are also affected. This helps the bug report become more visible without cluttering the comments.
⚠️ Only add a comment if you have new insights or background information not already mentioned. Off-topic or "+1" comments will be deleted to keep the discussion focused.
I think this is why my carpenter and stone mason have stopped working. If I don't remove the items from their personal inventory, they'll stand idle forever. However, once I remove the items from their inventory, they'll finally request the items from the warehouse that they need.
The changes in #11290 did not resolve my issue. My carpenter/stonemason will still stop working with partial ingredients in their inventory. If I remove the items, they will resume working. The workers get stuck in a QUERY_ITEMS->GET_RECIPE loop. 