MineColonies

MineColonies

65M Downloads

Stonesmelter/Brickmaker asking for non-descript fuel

Danickar opened this issue · 9 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues.

Are you using the latest MineColonies Version?

  • I am running the latest beta/release version of MineColonies for my Minecraft version.
    I am also running the latest versions of other mods that are part of my problem.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • Single Player
  • Multi Player

Minecraft Version

1.21

MineColonies Version

1.1.1159

Structurize Version

1.0.790

Related Mods and their Versions

No response

Current Behavior

The Brickmaker will ask for "Fuel" there is no icon in the request and it says the player is supposed to resolve this. If I try and click Fulfill nothing happens and if i click Cancel it just comes right back. This has been going on for a little while now, I do not know if it happened when the change from Stonesmelter to Brickmaker went in or if I just noticed the change at that time because of how much time I was spending in the hut trying to get it to work again.

I have tried this with multiple fuel options for the hut and only one fuel option for the hut. I was using just Dark Oak Logs and someone on Discord suggested that might be a problem so I switched it to just Charcoal and put a lot of Charcoal in the Warehouse, but the same thing continued to occur.

Expected Behavior

Brickmaker asks for actual fuel that can be delivered.

Reproduction Steps

After server reset the Brickmaker sometimes will start working properly, and then over time breaks.
I have fired and then rehired the Brickmaker, which sometimes fixes it, but again over time it breaks again.

When I could get the worker to work, they worked for a couple hours, but every time I would come back the next morning (real time) it was broken again. I do not know exactly how long it takes to go from a fixed state to a broken one, just that it happens every time.

Logs

https://gist.github.com/Danickar/ed4e8ce96f9175d4e3dbe0d37671b845

Anything else?

Image This is what the request looks like

Footer


Viewers

  • Add a 👍 reaction to the bug report if you are also affected. This helps the bug report become more visible without cluttering the comments.
  • ⚠️ Only add a comment if you have new insights or background information not already mentioned. Off-topic or "+1" comments will be deleted to keep the discussion focused.
commented

That actually means there is no valid fuel for them for a given task. As they can't use charcoal to make charcoal.

commented

But this should probably trigger an "select more fuels" interaction instead of empty list

commented

On discord, they mentioned the charcoal recipe was turned off

commented

This happens when the only fuel was charcoal - and there was charcoal in the warehouse
When I had it set to coal, charcoal, and dark oak logs, and there were at least 2 of those in the warehouse
When I have it set to only dark oak logs, of which I have over 6k in the warehouse

I also have the charcoal recipe turned off so that it can't try and create a loop by wanting to make what it needs to burn.

commented

As they can't use charcoal to make charcoal.

What's the though behind this? I've tested without that restriction/condition on 1.20.1 and it seems to work fine with just charcoal, he makes his own charcoal when he needs more. Added minimum stock module too for reserving a few stacks preventing couriers looting everything.

commented

Because if they run out of fuel, they cannot smelt logs into charcoal as they lack fuel

commented

They are requesting charcoal then (as they would anyway), though they never run out in practice with stock limit once they get started due to the ratio.

commented

I mean, without a minimum stock at the brickyard or warehouse, they would get themselves deadlocked.
We have had quite a few people with that issue, which is why it is now prevented at a much earlier level

commented

Yep, the stonesmelter needs to be allowed to maintain a buffer that is protected from couriers to prevent that kind of deadlock. Min stock is one way (that I have tested and is stable), another could be to use the fuel state