Lumberjack sapling use needs work

Question

Lumberjack sapling use needs work

MattBeard opened this issue 7 years ago · 16 comments

MattBeard commented 7 years ago

Minecolonies version

version 1.12.2-0.8.4802 or curse 7.5.6522.42411

Expected behavior

The lumberjack should be able to find saplings when required, even if they need to fetch them from their chest or request from deliveryman.

Ideal behaviour:

If no sapling is available at the end of chopping: After a waiting a while while (or slowly while waiting) scan the area within about 10 blocks of the base of the tree for saplings and move to collect if they are found.
If this does not work after a certain amount of time, check the lumberjack chest for the right sapling.
If not found in the chest, request a delivery.
Only "give up" as a last resort.

Additionally: There needs to be some way to scan the area a little above/below the chopping site for saplings and somehow collect them.

Actual behaviour

Often the lumber jack will end up "giving up" on planting a sapling for a tree because they don't have one. The newer improved behaviour of walking around while waiting helps a little, but certain trees such as the dark oak (which requires 4 saplings and does not drop all that many) often end up causing a problem. Jungle trees seem to be even worse as I have noticed that saplings often drop and sit in the canopy or on top of the trunk for so long they de-spawn.

This can be heartbreaking when you have spent hours on a long trip to find saplings for a rare tree and bring them back and plant them, only to notice later that they are all gone and not replanted.

Steps to reproduce the problem

Plant a few dark oak and/or jungle trees
Let the lumberjack chop them down
Watch them eventually run out of saplings
For extra fun: Set up a warehouse and deliveryman and watch the warehouse fill up with the saplings that your lumberjack is missing! Especially true if your guards patrol the area and pick them up.

Asherslab · Answer 1 · 2017-11-16T11:02:32.000Z

The warehouse / DMan are both getting a serious overhaul (Called the RS) this should fix what you mention with 4. (steps to reproduce). otherwise, yes they could use a bit of a change

PhoenixRiver · Answer 2 · 2017-11-16T18:52:39.000Z

This is also a problem with Natura install and Biomes O' Plenty due to there being a bunch of trees with low drop rates and possibly some of the trees having reduced drop rates - the Wooden Warehouse in Mine Colonies becomes very hard to build if you have to import the spruce wood but the drops from the tree often land on lower leaves and the drop rate is pretty bad.

PhoenixRiver · Answer 3 · 2017-11-21T15:53:01.000Z

Now running minecolonies-universal-1.12.2-0.8.4932 and lumberjack still having problems to the point that he isn't even collecting enough to keep oaks planted on a plantation I have created around his hut as below [/// : hut, - : nothing, . : tree]:

------------------///////////------------------
------------------///////////------------------
--.-----.-----.---///////////---.-----.-----.--
------------------///////////------------------
------------------///////////------------------
------------------///////////------------------
------------------///////////------------------
------------------///////////------------------
--.-----.-----.---///////////---.-----.-----.--
------------------///////////------------------
------------------///////////------------------
------------------///////////------------------
------------------///////////------------------
------------------///////////------------------
--.-----.-----.---///////////---.-----.-----.--
------------------///////////------------------
------------------///////////------------------
------------------///////////------------------

--.-----.-----.-----.-----.-----.-----.-----.--

Essentially a grid of trees with a gap of five between each tree - this means the lumberjack covers a lot of the ground where saplings fall regularly, despite this he still is running out of oak ones to replant and so there are now missing trees that I have to replace.

Raycoms · Answer 4 · 2017-11-21T15:56:08.000Z

I will have to go now, but I think the problem is that if he has a sapling he doesn't try to gather and that's why he ends up having none after a while as well. I'll add that he tries to gather the saplings after replanting always. I also will add that he checks in his hut for the right sapling after a shorter delay. 2017-11-21 15:53 GMT+00:00 PhoenixRiver <[email protected]>:

…

Now running minecolonies-universal-1.12.2-0.8.4932 and lumberjack still having problems to the point that he isn't even collecting enough to keep oaks planted on a plantation I have created around his hut as below [/// : hut, - : nothing, . : tree]: ------------------///////////------------------ ------------------///////////------------------ --.-----.-----.---///////////---.-----.-----.-- ------------------///////////------------------ ------------------///////////------------------ ------------------///////////------------------ ------------------///////////------------------ ------------------///////////------------------ --.-----.-----.---///////////---.-----.-----.-- ------------------///////////------------------ ------------------///////////------------------ ------------------///////////------------------ ------------------///////////------------------ ------------------///////////------------------ --.-----.-----.---///////////---.-----.-----.-- ------------------///////////------------------ ------------------///////////------------------ ------------------///////////------------------ ------------------------------ --.-----.-----.-----.-----.-----.-----.-----.-- ------------------------------ ------------------------------ ------------------------------ ------------------------------ --.-----.-----.-----.-----.-----.-----.-----.-- ------------------------------ ------------------------------ ------------------------------ ------------------------------ --.-----.-----.-----.-----.-----.-----.-----.-- ------------------------------ Essentially a grid of trees with a gap of five between each tree - this means the lumberjack covers a lot of the ground where saplings fall regularly, despite this he still is running out of oak ones to replant and so there are now missing trees that I have to replace. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1634 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGI9y-ppcKgmO1W5xWkliTj92loRHn21ks5s4vHegaJpZM4QgTv2> .

Neferdias · Answer 5 · 2017-11-21T22:58:20.000Z

I have noticed that my lumberjack won't replant birch or spruce saplings, even if they are in the chest. He'll just give up trying to plant them after standing around for 5 minutes. If I go grab one from the chest and throw it at his feet he'll plant it and carry on his way.

Raycoms · Answer 6 · 2017-11-21T23:10:55.000Z

Check out this Lumberjack: https://s3.eu-central-1.amazonaws.com/minecolonies/Minecolonies/Minecolonies_Branches/5088/minecolonies-universal-1.12.2-0.8.5088.jar Anything to complain about him? 2017-11-21 22:58 GMT+00:00 Neferdias <[email protected]>:

…

I have noticed that my lumberjack won't replant birch or spruce saplings, even if they are in the chest. He'll just give up trying to plant them after standing around for 5 minutes. If I go grab one from the chest and throw it at his feet he'll plant it and carry on his way. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1634 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGI9yzddVzBo-_USPjvrO_V2mwVysDPPks5s41WNgaJpZM4QgTv2> .

PhoenixRiver · Answer 7 · 2017-11-21T18:31:49.000Z

Those would make a big difference I think :) - thank you

Neferdias · Answer 8 · 2017-11-22T02:04:56.000Z

As far as I can tell it's now working as intended. (I'm only working off of what versions are posted to twitch/curse gaming app that i can get working, so that might be a me problem mostly)

PhoenixRiver · Answer 9 · 2017-11-22T15:56:44.000Z

Okay, the lumberjack worked well on the first and second day and it definitely solved the problem as he collected a lot of saplings... too many is not a bad thing I can just burn them for fuel! :) buuuut... the farmers just stopped moving around; when recalled they just stood by their chest not apparently farming at all - they didn't seem to collect any crops at all over three days (there are four farmers at level two with four working fields and two fields of barley). The builder still built and the deliveryman still delivered. However on the third day the farmers, builder and lumberjack didn't leave their houses, only the unemployed person wandered and the deliveryman did his job... TLDR; Lumberjack works better until the third day, farmers broken and possibly builder too also on third day unless she just doesn't wander unless she has a job. Unemployed people wander around just fine! :)

Raycoms · Answer 10 · 2017-11-22T18:19:34.000Z

Can you send me the log? Did you turn off the daylight cycles? 2017-11-22 15:56 GMT+00:00 PhoenixRiver <[email protected]>:

…

Okay, the lumberjack worked well on the first and second day and it definitely solved the problem as he collected a lot of saplings... too many is not a bad thing I can just burn them for fuel! :) buuuut... the farmers just stopped moving around; when recalled they just stood by their chest not apparently farming at all - they didn't seem to collect any crops at all over three days (there are four farmers at level two with four working fields and two fields of barley). The builder still built and the deliveryman still delivered. However on the third day the farmers, builder and lumberjack didn't leave their houses, only the unemployed person wandered and the deliveryman did his job... TLDR; Lumberjack works better until the third day, farmers broken and possibly builder too also on third day unless she just doesn't wander unless she has a job. Unemployed people wander around just fine! :) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1634 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGI9y-wna1-MUGpkZ8YyrfnDBzr5rQ-sks5s5EQ9gaJpZM4QgTv2> .

PhoenixRiver · Answer 11 · 2017-11-23T02:51:11.000Z

The only mine colonies relevant entries are the missing sound stuff and requests for more fields. I didn't turn off day night cycles I just sleep at night :) - I have no town wall yet! :)

MattBeard · Answer 12 · 2017-11-24T14:29:48.000Z

Odd, because my lumberjack had no saplings, I gave him 1 jungle - and he them planted 4

Raycoms · Answer 13 · 2017-11-24T14:45:34.000Z

He didn't get them elsewhere?

…

On Nov 24, 2017 12:31 PM, "MattBeard" ***@***.***> wrote: Odd, because my lumberjack had no saplings, I gave him 1 jungle - and he them planted 4 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1634 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGI9yyzsRnFBWmQWd4lqY8UQH7c17Tb6ks5s5tLdgaJpZM4QgTv2> .

MattBeard · Answer 14 · 2017-11-24T14:47:43.000Z

Pretty sure not. I will keep an eye on this!

MattBeard · Answer 15 · 2017-11-24T14:14:04.000Z

Has the lumberjack been updated to plant 4 jungle saplings when they only have 1 in their inventory? Seem a, um, creative, fix!

Raycoms · Answer 16 · 2017-11-24T14:18:30.000Z

No I haven't change anything in that code

…

On Nov 24, 2017 12:15 PM, "MattBeard" ***@***.***> wrote: Has the lumberjack been updated to plant 4 jungle saplings when they only have 1 in their inventory? Seem a, um, *creative*, fix! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1634 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGI9y0v_MQKIYdzwTpp_QkQvpomCm2Vrks5s5s8tgaJpZM4QgTv2> .

Share to

Minecolonies version

Expected behavior

Actual behaviour

Steps to reproduce the problem

--.-----.-----.-----.-----.-----.-----.-----.--

--.-----.-----.-----.-----.-----.-----.-----.--

--.-----.-----.-----.-----.-----.-----.-----.--