Deliveryman Hut Level 3 instantly clears blocks above structure post-clearing step
descention opened this issue · 4 comments
Minecolonies version
version 1.12.2-0.8.4832
Expected behavior
- leave blocks above structure alone
Actual behaviour
Steps to reproduce the problem
- Build a level 1 or 2 birch deliveryman hut into a hill.
- upgrade deliveryman hut to lvl 3
- ...
- Profit
this appears to be an issue with the scan, as it has included the air blocks above the building. This appears to be a custom hut, so it may be necessary to rescan the building without the air above. If it isn't custom, we will take a look at what's going on.
Would it make sense to programatically fix this by checking from top-most layer to bottom for an all air block level and removing it from the builder's work? Hitting any non-air block in the blueprint would stop the process.
If this were done, then buildings built into the sides of hills would be able to be more progressive rather than clearing a huge hole into the hill for a small hut.
The problem with this is that we'd need to detect if nothing follows this air level anymore. (Might be stuff hovering around for example.
Not much we can do about it since we didn't plan on building the buildings inside walls.
When we rescan them eventually we will scan them more exactly in height.