MineColonies

MineColonies

57M Downloads

[Feature Request] Herders breed Animania Animals

merdinarchfire opened this issue · 29 comments

commented

Minecolonies version

version 1.2.12

Expected behavior

  • Breeding Animania Cows check for male female.

Actual behaviour

  • Kills off Cows to only have 2 cows.

Config Request

  • I haven't seen an option for this, but it would be great if there was a config to change how many animals the herders keep alive. Or have them check for Male and Female when using Animania.
  • The issue is that my cowboy killed off the female adult then once the baby grew up it was a Bull, so I was stuck with 2 Bulls and no longer can get more cows.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

commented

Sadly i cannot add support for Animania without some serious changes, This does seem to be something i'd like to do in the future when i have the time though.

commented

Would iit be possible to check for named animals and don't kill these? This would allow to name two cows/pigs/whatever without breaking everything.

commented

That would be an option. @Asherslab would that work?

commented
commented

@Asherslab To fix the compatibility issue w/animania animals (and any other type). Can a config option be added (to the hut GUI or the config file) so that players can manually add modded animals?
Animals placed here would be treated in vanilla manner: bred like a vanilla mob type and killed. (for now).
If they require special breeding then player would have to do it or even automate it, but at least they would have the kills and drops, herders would be workable for now?

commented

https://github.com/capnkirok/animania/issues/600
Hey guys. Had a request on the Animania side for just this and wanted to add my name here. Let me know what you might need to proceed. One way to do this currently is to pull the EntityNames from all the animals to determine gender. Of course, each species is using the colloquial gender name (e.g. Doe & Buck for Rabbits), so it's tedious. But it would work. Let me know how I could further support.

Purp

commented

It is not that we are not looking in to this. It is just that we are slowing introducing new workers since this is a complete rebuild from scratch. And we have other priorities. It should however be relatively easy to do. Is there a way in code to detect if I have a female and male, in a list of entities?

commented

Also do you have a maven repo we can use in development?

commented

No maven (yet), but source code is here: https://github.com/capnkirok/animaniamod

As I mentioned, there is a way of telling if male or female, based on Entity Name. If you check for instanceof EntityCow, you can check the entity name string for the occurence of "animania:bull_" or "animania:cow_" or "animania:calf_"

The same goes for all animals.. but you will need to know the colloquial names currently. Easy to see this list from the lang file.

commented
commented

Yes, agree. Seems like a good reason to get a maven :)

commented

If you want you can use our buildsystem. It has an integrated maven/ivy repo.

commented

Wow i forgot i turned off github notifications ages ago, sorry about that.
@capnkirok that'd be awesome if you could get a maven, OR just use our buildsystem (we use docker and a few other things which makes our system work amazingly well)

@Wissi sadly it wouldn't be that simple, but the abov emention idea *should work

commented

Hopefully this will get support. Currently my cowboy just feeds the cows endlessly until he's out of wheat.

commented

@capnkirok maybe could you make an API call that can return male/female info based on names?

commented

@capnkirok Do you still need a BuildSystem / Repository?

commented

Did anything ever happen with this?

commented
commented

i also would love a compatibility, since i think this two mods would suit each other :D

commented

So is there any workaround to this right now? I really want to use the herders but Animania is an important mod for me so id rather not uninstall it. Im not sure if it would work to use spawn eggs to get vanilla cows just for the herder maybe?

commented
commented

Thanks for the quick response, using vanilla cows seems like the best option for now. My issue is though that using a vanilla spawn egg for cows it just spawns nothing after using it, something seems to completely deactive normal cows.

commented
commented

Alright thanks i will check why they won't spawn and look in the animania and familiar flora configs. I hope there will be a patch someday in the future when Purpalicious got more time :)

commented

Also the animals need water, that should be implemented too

commented

@ErdbeerbaerLP since Animania animals can drink from an infinite pool of water and water through, herders not necessarily have to take care about it, it could be automated in so many ways.

commented

Yeah, but the builder should. Level 1 for example does not have any water (i think i used wooden)

commented
commented

Will be added to a new joint mod compat issue.