MineColonies

MineColonies

56M Downloads

Builder and Building tool does not send block updates to client

zlainsama opened this issue ยท 22 comments

commented

Minecolonies version

version 0.4.1540

Expected behavior

  • issue a building with building tool, the box for that building is placed, and client can see it.
  • let a builder build, he starts clearing terrain, terrain is removed and client can see those changes.

Actual behaviour

  • issue a building with building tool, the box for that building is placed on server side, but client can't see it.
  • let a builder build, he starts clearing terrain, terrain is removed on server side, but client can't see those changes.

Steps to reproduce the problem

  1. Join a server, use the building tool to issue a building.
  2. Join a server, let a builder build.

Other notable things

  1. I was playing on the official server. I did not test in a single player world.
  2. The building tool caused my game to crash several times, the crash report says the game has run out of memory.
commented

There are multiple entries for a single key in the en_US file, and some of them have different lines written. I will try to translate those different lines and submit the file, have you and others to decide which one to stay.

commented

@zlainsama Please tell us what language you are translating to. We have a website where the translation will happen. But we would need to invite you with email and preferred language.

commented

Could you give us your email and the languages you speak fluently?
We actually have a program where we enter these strings which protects us
from multiple entries.

I could invite you there to update the values

2016-11-01 9:19 GMT-02:00 Lain MultipleInstances [email protected]:

There are multiple entries for a single key in the en_US file, and some of
them have different lines written. I will try to translate those different
lines and submit the file, have you and others to decide which one to stay.

โ€”
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#252 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGI9y6lgd5nrf3bhgEUIFR2PyAwHhwfLks5q5yBdgaJpZM4Kl3R9
.

commented

[email protected]
Thats my email, I am a native Chinese speaker.

commented

I mean zh_CN
I can also do ja_JP

commented

There is Chinese simplified, sp, traditional and hong kong I invited you to
the program.

Tell me if I have to adjust anything.

2016-11-01 9:23 GMT-02:00 Lain MultipleInstances [email protected]:

I mean zh_CN

โ€”
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#252 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGI9y1Tl0e-QN_eeUB1VvOldjUCRoycWks5q5yFAgaJpZM4Kl3R9
.

commented

You should assign me to Chinese simplified. traditional and simplified are not same, but most time they are same.

commented

Done =D

2016-11-01 9:35 GMT-02:00 Lain MultipleInstances [email protected]:

You should assign me to Chinese simplified. traditional and simplified are
not same, but most time they are same.

โ€”
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#252 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGI9y1DUpcxj77HPpw8ghejbL8-N0-Nkks5q5yQEgaJpZM4Kl3R9
.

commented

It's done.
Do I need to press anything?

commented

No, it persists automatically. Thank you for your contribution. When we add
new terms you should be notified automatically.
If you're interested anyway in joining our coding team to gain some
experience just fill in the application on the forums.

2016-11-01 11:10 GMT-02:00 Lain MultipleInstances [email protected]
:

It's done.
Do I need to press anything?

โ€”
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#252 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGI9y9euvRkEwwkXfiwMLH_9dpYi5k6_ks5q5zpfgaJpZM4Kl3R9
.

commented

Okay.

commented

Hello, this is a problem when the server uses a lot of resources (close to
100%).
The client does only update when you log off and back in. That's a
minecraft and not a minecolony problem.
The buildTool crash happens when you don't assign enough main memory to
minecraft. We will improve it in the next months though.

Closed.

2016-11-01 6:19 GMT-02:00 Lain MultipleInstances [email protected]:

Minecolonies version

version 0.4.1540
Expected behavior

  • issue a building with building tool, the box for that building is
    placed, and client can see it.
  • let a builder build, he starts clearing terrain, terrain is removed
    and client can see those changes.

Actual behaviour

  • issue a building with building tool, the box for that building is
    placed on server side, but client can't see it.
  • let a builder build, he starts clearing terrain, terrain is removed
    on server side, but client can't see those changes.

Steps to reproduce the problem

  1. Join a server, use the building tool to issue a building.
  2. Join a server, let a builder build.

Other notable things

  1. I was playing on the official server.
  2. The building tool caused my game to crash several times, the crash
    report says the game has run out of memory.

โ€”
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#252, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AGI9y8nUL_z0xojvnL-OuOix984YtU9nks5q5vX1gaJpZM4Kl3R9
.

commented

I'm a modder myself, I have encountered this problem before, with my own mod.
I believe this is a problem with the flags set to the setBlock(), which does not tell the game to send block updates to client.
Could you consider checking mod codes again? or tell me where to help you check, I'm not going to find it by myself.

commented

We normally set the flags to 3 that should post updates to the client. And build tool f.e. works perfectly fine, as long as you are near it. Once you are somewhat far, it stops.
It could be that sponge is interfering with it...

commented

I have tested this in a single player world, they worked perfectly fine. Sorry.
Might be sponge then...

commented

Well, we have to tweak the sponge config then >.>

@zlainsama Would you be interested in helping the mod out? :)

commented

I would like to, but I do not have any experience in contributing a large project.
I have only worked on some small projects.

commented

@zlainsama that will be no problem. Most tasks don't need the whole codebase to work with.

If you are interested: http://minecolonies.com/recruitment

commented

After some consideration, I decided not to apply.
But I think I can help when the mod decides to support other languages.

commented

@zlainsama Well, we already support multiple languages. We are translated into I think about 10 or so and are always looking for more translators.

commented

Where can I help translations?