Town Hall - Should Save build order.

Question

Town Hall - Should Save build order.

bob0bob opened this issue 6 years ago · 6 comments

bob0bob commented 6 years ago

When you take the time to reorder the build order from the town hall gui. This should be saved. On reopening the world again. The order is lost and I have to reorder the building process again.

Raycoms · Answer 1 · 2018-07-06T17:01:51.000Z

It should actually save it, but it might need a few minutes to save this (I will rework this soon, but for now we need it for performance reasons) 2018-07-06 13:54 GMT-03:00 bob0bob <[email protected]>:

…

When you take the time to reorder the build order from the town hall gui. This should be saved. On reopening the world again. The order is lost and I have to reorder the building process again. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2595>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGI9y6LxqrLLBhpzrHIs9ryARYl8p-5wks5uD5ZYgaJpZM4VFwDj> .

bob0bob · Answer 2 · 2018-07-06T21:02:12.000Z

Fixed in PR #2593

bob0bob · Answer 3 · 2018-07-06T18:22:20.000Z

Based on the code. when writing to the NBT file. the priority is not saved. So on load everything is set to 0 again. Class AbstractWorkOrder looks like it holds the priority but the writeNBT and createFromNBT is not using that variable. I've have code changes to fix this. if you want me to submit them for review.

Raycoms · Answer 4 · 2018-07-06T18:48:51.000Z

Ahh, didn't know that I had forgot that, then we have to add that there. 2018-07-06 15:22 GMT-03:00 bob0bob <[email protected]>:

…

Based on the code. when writing to the NBT file. the priority is not saved. So on load everything is set to 0 again. Class AbstractWorkOrder looks like it holds the priority but the writeNBT and createFromNBT is not using that variable. I've have code changes to fix this. if you want me to submit them for review. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2595 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGI9y0YU_5JBLOm_oDIKHhMlS6DFOV-uks5uD6regaJpZM4VFwDj> .

bob0bob · Answer 5 · 2018-07-06T18:54:58.000Z

I tried to submit changes but I guess you can only have one pull request from one branch to another. It combined the changes into the PR for the enhancement to the baker.

Can you have more than one. When I click on new pull request and then select across forks. it pulls up the one pending. I guess you can't have more than one.

Raycoms · Answer 6 · 2018-07-06T18:56:51.000Z

Weird, it should work with multiple PRs, but combining it works as well 2018-07-06 15:54 GMT-03:00 bob0bob <[email protected]>:

…

I tried to submit changes but I guess you can only have one pull request from one branch to another. It combined the changes into the PR for the enhancement to the baker. Can you have more than one. When I click on new pull request and then select across forks. it pulls up the one pending. I guess you can't have more than one. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2595 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGI9yxaM1G1R1uel2s-rbxChtH3uIF_Nks5uD7KDgaJpZM4VFwDj> .

Share to