MineColonies

MineColonies

56M Downloads

Command for inactive colonies. [$15]

Raycoms opened this issue ยท 17 comments

commented

The colony info command should have stored when the colony has last been loaded.
Might be useful to have a command which removes all colonies which have not seen a player in over a month?

Bountysource


Did you help close this issue? Go claim the $15 bounty on Bountysource.

commented

This should also have some config options for how long till it considers a colony abandoned. And have a list of colonies that are close to expiring. And at best delete them automatically (per config).

commented

I actually wouldn't delete them automatically.
I would make it configurable how much time without owner/officer logging in and they will be shown in a list.
And you can do "flush list" (to delete all of them) or delete parts of them manually with the delete command.

commented

I am busy making the changes for a PR as requested in the issue and found the word abandoned to be a long word to type. So was wondering if the word deserted might not be a better for the command.

commented

@wesselOC This command won't be called often I guess. I'm fine with both, but I guess abandoned is more intuitive and their difference it not that much. We can always introduce aliases for power users later ๐Ÿ˜‰

@Raycoms we should make a command that flushes manually and a config option to check every hour or so automatically for servers that want that.

commented

@wesselOC Since I can't comment on your proposal on bountysource I'll do it here:
Colony load times can be problematic, because all colonies can be loaded by explorers f.e.
So what we currently envision is storing last seen for each player (f.e. in login/logoff/other events) and then checking all members of a colony and taking the max of that.

Having a config option that automatically triggers the cleanup command would be nice to have too.

commented

I'd say it should have an option to trigger in the config what is "outdated" like in weeks "20" weeks. and then you can execute the /mc colonies getAbandoned
which will display the whole list with a little "x" to remove them.
or you can /mc colonies flushAbandoned which remove all of them.

commented

@wesselOC any news on your pr so far? Did you start working already?

commented

@wesselOC I guess we can safely assume you won't work on this feature?

commented
commented

@wesselOC alright, no problem :)
If you need any help with getting around the codebase, just ask.

commented

With regards to inactive colonies: Would it not also be a good idea to let them degrade?

commented

That would be a good thing later on. And can be easily added on to the automatic cleanup from this issue

commented
commented

@wesselOC what is the status of this?

commented

so interestingly enough i just did this

commented

i can do a "soon to be deleted" if needed tho =D

commented

Done that.