MineColonies

MineColonies

Mods
53M Downloads

Can't craft Spruce Shingles in Sawmill

Dranemra opened this issue ยท 1 comments

commented

Minecolonies version

Version: 1.12.2-0.10.146-ALPHA

Expected behavior

Looking to have Sawmill craft spruce shingles for building.

Actual behaviour

Trying to add the recipe to the sawmill, I get the following error:
"Unable to store the blueprint. Either the Sawmill has no space for any more blueprints, or the blueprint doesn't correspond with its profession."

Steps to reproduce the problem

  1. At the Sawmill hut block, Click on Teach Recipes
  2. Put the components in the grid as per recipe for the spruce shingle
  3. You will get the error stated above.

2019-01-26_17 50 39

commented

minecolonies/src/main/java/com/minecolonies/coremod/colony/buildings/workerbuildings/BuildingSawmill.java

Line 117 in 539ff23

if (item instanceof ItemBlock && (((ItemBlock) item).getBlock() instanceof BlockShingle || ((ItemBlock) item).getBlock() instanceof BlockShingleSlab))

This line is never evaluated to be true, because one of shingle ingredients: brick
somehow in my build are having name: ingotBrick
because of this line,

minecolonies/src/main/java/com/minecolonies/coremod/colony/buildings/workerbuildings/BuildingSawmill.java

Line 107 in 539ff23

else if(name.contains("ingot") || name.contains("stone") || name.contains("redstone") || name.contains("string"))

it will return false before evaluating it's shingle or not