Barbarians status not reporting properly.
Dranemra opened this issue · 7 comments
Minecolonies version
Version: minecolonies-1.12.2-0.10.282-ALPHA-universal.jar
Expected behavior
- Barbarians raiding colony are broadcast as 'Defeated' when killed or time out.
Actual behaviour
- Barbarian raids are no longer registering properly. This is more notable now with Dynamic Claims as colony borders are no longer regular. Barbarians are being flagged as 'Defeated' when walking out of colony borders, but don't register as a new raid when they wander back into the colony.
Steps to reproduce the problem
- Notice that there is a pending Barbarian Raid that night
- Get first notice as the barbarians skim in and out of the colony that all of them have been defeated.
- Get one or more messages for each time their pathing takes them out of the colony borders
- The barbarians aren't actually defeated, they are still very much there, and will eventually find the colony center.
- Because they were previously marked as defeated, the event is marked as over, citizens will leave their houses thinking it's safe.
- Barbarians continue to raid colony till they time out (or are killed by guards/player), killing citizens who are now just trying to perform their daily tasks.
- This is leaving the colony seriously vulnerable if they barbarians are raiding an otherwise undefended section.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
THis also can happen if the barbarians spawn too far away from your location and/or you move too far away from their location. I don't know if the distance is based on something in Minecolonies or Minecraft related but my SP colony is large enough that if barbarians spawn on one end of it, and I'm sleeping in my player home on the other end, they will 'instantly' be listed as defeated but still be rampaging through the other end's area. Even moving over that end doesn't 'reset' the count, instead killing each one gives you the "you've successfully defended your colony" message.
@Raycoms since barbarians are pretty dangerous when not under control - can we add a config option so they will act like chunk loaders (i.e. fake player with 3 chunks update radius)?
the message thing is solvable bug, but will it be enough?
@Dranemra nah, I was thinking about that once a raid gets spawn it will act like a chunk loader until it gets killed - to prevent desync issue when unloading/loading that part of colony, i.e. it will not be active forever
